This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100317/

Ship it!

Looks good to me!

- Dan Leinir Turthra

On January 7th, 2011, 9:51 p.m., Giulio Camuffo wrote:

Review request for Gluon.

By Giulio Camuffo.

Updated Jan. 7, 2011, 9:51 p.m.

Description

Currently when in the creator a gameobject or component gets disabled it doesn't hide immediately. This patch fixes that behaviour, calling initialize() or cleanup() on the object.
To ensure initialize() won't be called by setEnabled() before actually wanted, I had to keep track if the gameobject's initialize() was called, with a new bool in the private class and a new initialized() method used by Component.

Diffs

engine/component.cpp (03edc8d)
engine/gameobject.h (403c018)
engine/gameobject.cpp (1f29de8)
engine/gameobjectprivate.h (82ac665)
engine/gameobjectprivate.cpp (49823d5)

View Diff