|Re: [eigen] Array of complex numbers|
[ Thread Index |
| More lists.tuxfamily.org/eigen Archives
- To: eigen <eigen@xxxxxxxxxxxxxxxxxxx>
- Subject: Re: [eigen] Array of complex numbers
- From: Gael Guennebaud <gael.guennebaud@xxxxxxxxx>
- Date: Thu, 10 Jan 2019 23:09:37 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=qEQbJrmGkD2Wj8pbnp2r2iaTb+1ehWJk7olFoE24w4E=; b=oZ7Mp5u+rMCzjI3my6m5q9ihBWKDZm+PYAu06TKHwylFpYOT++a2yqvA+o6zndW6pd YJZ9QiWqT+KaFYnIAxrmbzvy1BYbahyyzC3SlhCAInf2S8OK5PG6H1o4tNg+OBNVVkBy OC6LtlEJzic6d2gNe4ekvW9XPcJ2quyDcWUBjAOBZRq+znYRyR7bpvXyjh7NE7yNFuru bFhG7SVhXLTtucJX/fkaT1lpLY+yPC0Xy77TO7THMoS3V+xkujqeeQsBf7zhcpTW6Kl4 fqNLsGt3aqeeimNyjQgcJkgPxkm7B/Y14StN0+1ND/2KTzXi0kSQ4pBaHXa+4iew3M+r QPAQ==
for pzero, you need the devel branch of Eigen, or just replace it by pset1<Packet>(0).
For linear combination with complex coeffs I don't think it's possible to get close SoA for such small (i.e. in-cache) arrays.
You are right about the operations. Obviously, for the “linear combination”, I am interested in the case where rk are complex numbers.
I have tried to compile your code that implements the scalar product, but I don’t have any definition for pzero? Where is it?
> On 10 Jan 2019, at 22:25, Gael Guennebaud <gael.guennebaud@xxxxxxxxx> wrote:
> just to be sure I fully understood the operations you're considering, let's assume you have:
> VectorXcf A1(300), A2(300), ...;
> complex<float> c1, c2, ...;
> float r1, r2, ...;
> then "Scalar product" means:
> and "Linear combination" means:
> r1*A1 + r2*A2 + ...
> If this is right, then linear combination with real coefficients should already be 100% optimal and the only problematic operation could be dot products because of the complex*complex product overhead. I think those can be optimized while keeping an AoS layout by accumulating within multiple packets that we combine only at the end of the reduction instead of doing and expensive combination for every product. This is similar to what we do in GEMM.
> I gave it a shot, and I get similar speed than with a SoA layout. See attached file. This is a proof of concept : AVX only, no conjugation, n%16==0, etc.
> I think this can be integrated within Eigen by generalizing a bit the current reduction code to allow for custom accumulation packets.