[eigen] C++17 compatibility

[ Thread Index | Date Index | More lists.tuxfamily.org/eigen Archives ]

To: "eigen@xxxxxxxxxxxxxxxxxxx" <eigen@xxxxxxxxxxxxxxxxxxx>
Subject: [eigen] C++17 compatibility
From: Basil Fierz <basil.fierz@xxxxxxxxxxx>
Date: Wed, 1 Aug 2018 06:49:00 +0000
Accept-language: en-US
Authentication-results: spf=none (sender IP is ) smtp.mailfrom=basil.fierz@xxxxxxxxxxx;
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sd4wCJpg4XgMeIA0OjOfmDLIJpgBkyx3YJ89W2/GSuU=; b=ly/r17wVSJ6ORLNfsym5oJvPugO5De9DqlLJOqN0HYZQThCGDWrMe0aWYrbdLQa897CsnJ55ogErJp+mhFKdPBHN1MaTWb2coyEtgcV6l9tE3SbnXSxpnG8ozg9FmWD+jvBooICeuYTLCELhAil9DaUZpVHdeAV6OYGalKvt1Nmv0LVhl/S+gg9gVHEgTWp/nkxYYTT9LXK0e9HOGbWCza8QfkiFdTiEzZ65//riRZE0WKkEf9lBkO6ZKrR3FufVu66kqnPwEcIdasji0qHx3AAFGbDVrZWVi2FWlDHQ5I50p7bXAwhLnP6KNgkGpjEU0OkHs/VQlU4snF6T3h4w5w==
Thread-index: AdQpYsN0zdm+xI5NTPuc9or8vl1GQg==
Thread-topic: C++17 compatibility

Hi Eigen-developers,

As part of porting my codebase to C++17, I have tried to fix/work around the deprecation of std::result_of. The attached patch essentially reimplements Eigens result_of in terms of std::invoke_result. As this is only available on modern compilers anyway, I’ve decided to use more recent C++ features in general.

As my main platform is Windows/MSVC, I am not sure if the feature check on GCC/clang is bullet proof (I’ve basically started with the one for result_of).

Any feedback is welcome, if you believe this patch is reasonable (as is, or with modifications), I will open a pull-request.

Best regards,

Basil Fierz

Attachment: invoke_result.patch
Description: invoke_result.patch

Messages sorted by: [ date | thread ]
Next by Date: Eigen 3.3 vs 3.2 Performance (was RE: [eigen] 3.3-beta2 released!)
Next by thread: Eigen 3.3 vs 3.2 Performance (was RE: [eigen] 3.3-beta2 released!)

Mail converted by MHonArc 2.6.19+

http://listengine.tuxfamily.org/