Re: [eigen] [patch] Add support for SuperLU 5

[Christoph Hertzberg <chtz@xxxxxxxxxxxxxxxxxxxxxxxx>]

Hi,

sorry for not addressing this, for that long.

There are some issues with your patch:
My cmake seems not to like check_c_source_compiles (maybe because the 
project is build as C++ project), replacing it by 
check_cxx_source_compiles (as for the other checks) makes it work fine here.


Also, this line does not work for SuperLU < 5.0:

  #if SUPERLU_VERSION_VAR >= 5.0

First of all, there was no VERSION_VAR defined prior to 5.0. Also, 
because you can't use floating point numbers in a preprocessor #if.

I don't have SuperLU 5 installed at my system, but just checking a 
downloaded version from:
  http://crd-legacy.lbl.gov/~xiaoye/SuperLU/
it seems like the actual definition of the version number is done via:

  #define SUPERLU_MAJOR_VERSION     5
  #define SUPERLU_MINOR_VERSION     2
  #define SUPERLU_PATCH_VERSION     1

So we could replace that line by
  #if defined(SUPERLU_MAJOR_VERSION) && SUPERLU_MAJOR_VERSION >= 5

If that works for you, I'll be pushing it that way.

Cheers,
Christoph




On 2016-06-19 19:02, Christoph Grüninger wrote:
> Dear Eigen devs,
> please find attached a patchset to add support for SuperLU. This is
> meant to fix bug 1119.
> I haven't figured out how testing works within Eigen, so it is possible
> that the patch does not work. What should I do test my changes or where
> can I read about it?
>
> Bye
> Christoph

--
 Dipl. Inf., Dipl. Math. Christoph Hertzberg

 Universität Bremen
 FB 3 - Mathematik und Informatik
 AG Robotik
 Robert-Hooke-Straße 1
 28359 Bremen, Germany

 Zentrale: +49 421 178 45-6611

 Besuchsadresse der Nebengeschäftsstelle:
 Robert-Hooke-Straße 5
 28359 Bremen, Germany

 Tel.:    +49 421 178 45-4021
 Empfang: +49 421 178 45-6600
 Fax:     +49 421 178 45-4150
 E-Mail:  chtz@xxxxxxxxxxxxxxxxxxxxxxxx

 Weitere Informationen: http://www.informatik.uni-bremen.de/robotik