Re: [eigen] Accidental push/merge for s390x SIMD :)

[Konstantinos Margaritis <markos@xxxxxxxxxxx>]

Στις 14-04-2016, ημέρα Πεμ, και ώρα 22:58 +0200, ο/η Gael Guennebaud έγραψε:

the following one is probably not critical:

          7 - nomalloc_3 (OTHER_FAULT)

nomalloc_3: /srv/data/eigen/Eigen/src/Core/MapBase.h:170: void Eigen::MapBase<Derived, 0>::checkSanity(typename Eigen::internal::enable_if<(Eigen::internal::traits<OtherDerived>::Alignment > 0), void*>::type) const [with T = Eigen::Map<Eigen::Matrix<float, -1, 1>, 16, Eigen::Stride<0, 0> >; Derived = Eigen::Map<Eigen::Matrix<float, -1, 1>, 16, Eigen::Stride<0, 0> >; typename Eigen::internal::enable_if<(Eigen::internal::traits<OtherDerived>::Alignment > 0), void*>::type = void*]: Assertion `( ((size_t(m_data) % internal::traits<Derived>::Alignment) == 0) || (cols() * rows() * innerStride() * sizeof(Scalar)) < internal::traits<Derived>::Alignment ) && "data is not aligned"' failed.

but those four are really concerning:
         27 - mixingtypes_5 (OTHER_FAULT)

mixingtypes_5: /srv/data/eigen/Eigen/src/Core/MapBase.h:170: void Eigen::MapBase<Derived, 0>::checkSanity(typename Eigen::internal::enable_if<(Eigen::internal::traits<OtherDerived>::Alignment > 0), void*>::type) const [with T = Eigen::Map<Eigen::Matrix<std::complex<float>, -1, 1>, 16, Eigen::Stride<0, 0> >; Derived = Eigen::Map<Eigen::Matrix<std::complex<float>, -1, 1>, 16, Eigen::Stride<0, 0> >; typename Eigen::internal::enable_if<(Eigen::internal::traits<OtherDerived>::Alignment > 0), void*>::type = void*]: Assertion `( ((size_t(m_data) % internal::traits<Derived>::Alignment) == 0) || (cols() * rows() * innerStride() * sizeof(Scalar)) < internal::traits<Derived>::Alignment ) && "data is not aligned"' failed.

         33 - packetmath_5 (OTHER_FAULT)

fixed and committed, will merge when I've fixed the other problem as well.

        113 - product_small_5 (OTHER_FAULT)

product_small_5: /srv/data/eigen/Eigen/src/Core/MapBase.h:170: void Eigen::MapBase<Derived, 0>::checkSanity(typename Eigen::internal::enable_if<(Eigen::internal::traits<OtherDerived>::Alignment > 0), void*>::type) const [with T = Eigen::Map<Eigen::Matrix<float, -1, 1>, 16, Eigen::Stride<0, 0> >; Derived = Eigen::Map<Eigen::Matrix<float, -1, 1>, 16, Eigen::Stride<0, 0> >; typename Eigen::internal::enable_if<(Eigen::internal::traits<OtherDerived>::Alignment > 0), void*>::type = void*]: Assertion `( ((size_t(m_data) % internal::traits<Derived>::Alignment) == 0) || (cols() * rows() * innerStride() * sizeof(Scalar)) < internal::traits<Derived>::Alignment ) && "data is not aligned"' failed.

        487 - geo_quaternion_2 (OTHER_FAULT)

geo_quaternion_2: /srv/data/eigen/Eigen/src/Core/MapBase.h:170: void Eigen::MapBase<Derived, 0>::checkSanity(typename Eigen::internal::enable_if<(Eigen::internal::traits<OtherDerived>::Alignment > 0), void*>::type) const [with T = Eigen::Map<Eigen::Matrix<double, 4, 1>, 16, Eigen::Stride<0, 0> >; Derived = Eigen::Map<Eigen::Matrix<double, 4, 1>, 16, Eigen::Stride<0, 0> >; typename Eigen::internal::enable_if<(Eigen::internal::traits<OtherDerived>::Alignment > 0), void*>::type = void*]: Assertion `( ((size_t(m_data) % internal::traits<Derived>::Alignment) == 0) || (cols() * rows() * innerStride() * sizeof(Scalar)) < internal::traits<Derived>::Alignment ) && "data is not aligned"' failed.

Of those I'm more worried of the last one as I thought I that alignment was handled correctly for doubles (packetmath passes).

I'm going to look at it a bit more in the weekend.

Regards

Konstantinos