Re: [eigen] It is time for a 3.2.5

[Gael Guennebaud <gael.guennebaud@xxxxxxxxx>]

Sergiu, thank you for your report. However I prefer not fixing this one for 3.2.5 as there is a high risk to break other compilers.

Over the last few days I fixed a few additional issues in the 3.2 branch. Let's do the release today.

Gael.

On Wed, Jun 10, 2015 at 1:03 PM, Sergiu Dotenco <sergiu.dotenco@xxxxxxxxx> wrote:

On 6/8/2015 11:54 AM, Gael Guennebaud wrote:
>
> Hi list,
>
> the 3.2 branch receives tons of fixes and improvements since the latest
> 3.2.4 release in January. So it's really time to release a new version
> of this branch.
>
> You can have a look at the current list of
> changes: http://eigen.tuxfamily.org/index.php?title=ChangeLog#Eigen_3.2.5
>
> Let us know if you see any major issues that have not been already handled.
>
> As usual, the link to the respective source
> is: https://bitbucket.org/eigen/eigen/get/3.2..tar.gz

> <https://bitbucket.org/eigen/eigen/get/3.2.tar.gz>
>
> Cheers,
> Gaël

When compiling using Visual Studio 2013 (x64), I see a lot of C4522
warnings:

d:\projects\eigen\eigen\src/Geometry/Quaternion.h(291): warning C4522:
'Eigen::Quaternion<float,0>' : multiple assignment operators specified
d:\projects\eigen\eigen\src/Geometry/arch/Geometry_SSE.h(22) : see
reference to class template instantiation 'Eigen::Quaternion<float,0>'
being compiled
d:\projects\eigen\eigen\src/Geometry/arch/Geometry_SSE.h(38) : see
reference to class template instantiation
'Eigen::internal::quat_product<1,Derived,OtherDerived,float,1>' being
compiled
d:\projects\eigen\eigen\src/Geometry/Quaternion.h(291): warning C4522:
'Eigen::Quaternion<double,0>' : multiple assignment operators specified
d:\projects\eigen\eigen\src/Geometry/arch/Geometry_SSE.h(63) : see
reference to class template instantiation 'Eigen::Quaternion<double,0>'
being compiled
d:\projects\eigen\eigen\src/Geometry/arch/Geometry_SSE.h(109) : see
reference to class template instantiation
'Eigen::internal::quat_product<1,Derived,OtherDerived,double,1>' being
compiled

The definition of

template<class Derived>
EIGEN_STRONG_INLINE QuaternionBase<Derived>&
QuaternionBase<Derived>::operator=(const QuaternionBase<Derived>& other);

seems to be redundant since there's already

template<class Derived>
template<class OtherDerived>
EIGEN_STRONG_INLINE Derived& QuaternionBase<Derived>::operator=(const
QuaternionBase<OtherDerived>& other);