Re: [eigen] eigen3 msvc 1900

[Gael Guennebaud <gael.guennebaud@xxxxxxxxx>]

Hi,

which Eigen version are you referring to? In Eigen 3.2, the respective lines in Macro.h are as follows:

https://bitbucket.org/eigen/eigen/src/9716ca6de21838927484f3c33050648bac890ac3/Eigen/src/Core/util/Macros.h?at=3.2#cl-316

and do not match your patch at all.

So, please, could you paste the errors you get when using Eigen 3.2:

$ hg clone https://bitbucket.org/eigen/eigen/ eigen3.2

$ cd eigen3.2

$ hg up 3.2

and if you still get errors, send us a true patch file using, for instance:

$ hg diff

Thank you.

On Thu, Dec 18, 2014 at 2:31 AM, Yann Nayn <yann.nayn@xxxxxxxx> wrote:

Hi,

it seems that patching

Core/util/Macros.h line 310 as follows:

#if _MSC_VER >= 1900
    #define EIGEN_INHERIT_ASSIGNMENT_EQUAL_OPERATOR(Derived) \
        using Base::operator =;\
  EIGEN_STRONG_INLINE Derived& operator=(const Derived& other) { Base::operator=(other); return *this; }
#else
    #define EIGEN_INHERIT_ASSIGNMENT_EQUAL_OPERATOR(Derived) \
        using Base::operator =;
#endif 

and Core/MapBase.h line 310 as follows:

Derived& operator=(const MapBase& other)
    {
      return MapBase<Derived, ReadOnlyAccessors>::Base::operator=(other);
    }
   
    using MapBase<Derived, ReadOnlyAccessors>::Base::operator=;
   

lets Eigen3 compile smoothly using msvc 1900 22310.1

Yann