| Re: [eigen] g++ -Wshadow warnings |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
On Wed, Feb 26, 2014 at 7:38 AM, Christoph Hertzberg
<chtz@xxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On 26.02.2014 13:34, Jitse Niesen wrote:
>>
>> On Mon, 24 Feb 2014, Brad Bell wrote:
>>
>>> Does eigen wish to support the -Wshadow flag on the g++ compiler ?
>>
>>
>> Yes, why not.
>
>
> I just (locally) added
> ei_add_cxx_compiler_flag("-Wshadow")
> to the main CMakeList. At the moment, compiling the tests floods the screen
> with warnings. I don't think any of these will be hard to fix, but I guess
> we should postpone that to after 3.2.1.
>
It would be great to see these fixed up, we currently suppress the
errors from Eigen. If it slips I will see if I can find a little time
to help if patches would be well received.
Marcus