Re: [eigen] Student contribution |

[ Thread Index | Date Index | More lists.tuxfamily.org/eigen Archives ]

*To*: eigen <eigen@xxxxxxxxxxxxxxxxxxx>*Subject*: Re: [eigen] Student contribution*From*: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>*Date*: Sun, 16 Jun 2013 17:08:20 -0400*Cc*: simon.courtemanche@xxxxxxxx, Pierre ZOPPITELLI <Pierre.Zoppitelli@xxxxxxxxxxxxxxx>, Nicolas Carré <carren@xxxxxxxxxxxxxx>, Jean CECCATO <Jean.Ceccato@xxxxxxxxxxxxxxx>*Dkim-signature*: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Ga5TRIMiyD500JAd/bR7EUWn/IzHPyS2/9UYI5t4oiQ=; b=Y8pRKSR/p2gWGrmMLJZsj+cD3dkqDssHw2SWGuajST+HFDkXjv87yAw6tGDb1wNmRJ CnHWasuO4mWTF+EH+OZj+okpVW1oog7mlzonNVigo58Y+5iP4+nq92N7mrctnTyce3K1 hXD0Fd2s6OnWkBpfEZLfS+fSDYzhNoGBcOZLTLdnoTESogPmAHudNDv1uesrSWmHOnG4 aWvfplggE0nMoTcWSqdMarH0CY22eGWMD8M9xTw+CZKaHC6+u0MDlYg6wlO993oJxvhC yxvRF+7rZom/s7ZMXYb/nS1lX8j4eSRaykM1M6mQ2NJRhiWdHl0qTK/Q8T5B96yi1WES 3T7w==

Hi,

Maybe I shouldn't have hopped onto this thread: I have been away from the Eigen project for a long while, and it's up to the current maintainers, not me, to decide on the specifics here.My personal opinion is that what we really want, as described in bug 67, is something similar to LAPACK's SGESDD. As Gael pointed out, this should bring an order-of-magnitude speed improvement over JacobiSVD, at least on already-bidiagonal matrices (the rest is up to the speed of bidiagonalization, which can we worked on independently).

A 1.7x speed improvement is always nice, but I will leave it up to current maintainers to decide where exactly the bar is for deciding to include a new SVD algorithm. Of course, as you suggested, there is always the option to include it in unsupported/ so that it can be easily found and improved by other people.

The other factor to consider to what extent this code provides the right basis for a future implementation of the SGESDD-like SVD.

In any case, do feel free to reply on bug 67 to mention this work!

Finally I also want to say that this work shows that the students have very solid C++ skills, as Eigen is a notoriously difficult C++ codebase to get familiar with. Regardless of inclusion in Eigen, this should be considered a successful student project.

Thanks,

Benoit

2013/6/16 Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx>

Hi,

(I'm one of the school supervisors of the project)

I can't speak for students, but a 100% complete implementation seems

Benoit Jacob <jacob.benoit.1@xxxxxxxxx> writes:

> I think that actually implementing the SVD code (without resorting to

> JacobiSVD), and supporting complex matrices, should be the two main

> missing prerequisites to consider including this in Eigen.

unlikely to happen before the end of the project (which is next

wednesday, and there are other non-technical tasks which will take time

too). Students have an internship after the project, so they are

unlikely to find more time to work on this (although I do encourage all

of them to continue contributing!).

In any case, we should find a way for the work already done to be useful

to Eigen. I think that leaving some unmaintained code on bitbucket has

little chance to be actually useful one day.

Obviously, a nice scenario would be that someone from the Eigen

community volunteers to continue the work started and merge it.

If not, we have to find a way to make it easy for someone to take over

the project. At least, mentionning the bitbucket repository on the

appropriate bug may help:

http://eigen.tuxfamily.org/bz/show_bug.cgi?id=67

(together with some instructions on what's still to be done)

I had the feeling that merging at least part of the code into Eigen

could help too, even if it doesn't bring immediate and substancial

benefits. But I do not know Eigen enough to really tell, and I

understand that merging right before a release is not a good idea.

How do you see the future of this project? Is anyone interested in

continuing the work?

Thanks,

--

Matthieu Moy

http://www-verimag.imag.fr/~moy/

**Follow-Ups**:**Re: [eigen] Student contribution***From:*Benoit Jacob

**Re: [eigen] Student contribution***From:*Matthieu Moy

**References**:**[eigen] Student contribution***From:*BRUN Gauthier

**Re: [eigen] Student contribution***From:*Benoit Jacob

**Re: [eigen] Student contribution***From:*Matthieu Moy

**Messages sorted by:**[ date | thread ]- Prev by Date:
**Re: [eigen] Student contribution** - Next by Date:
**Re: [eigen] Student contribution** - Previous by thread:
**Re: [eigen] Student contribution** - Next by thread:
**Re: [eigen] Student contribution**

Mail converted by MHonArc 2.6.19+ | http://listengine.tuxfamily.org/ |