|Re: [eigen] SuperLU include directories|
[ Thread Index |
| More lists.tuxfamily.org/eigen Archives
- To: eigen <eigen@xxxxxxxxxxxxxxxxxxx>
- Subject: Re: [eigen] SuperLU include directories
- From: Gael Guennebaud <gael.guennebaud@xxxxxxxxx>
- Date: Sun, 17 Feb 2013 21:39:04 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:content-type; bh=ikdEzqPTpx1rZJd7CHhzpbLYKDy3AfDsCxQloo+Xibc=; b=BeYayXo/fPSFh/FyD55+wFNIm7eRVPMGwekgDonvrM299mTS4zCa/7ZYW6d0iZVgPj 6/z7MpX84ZjgJFxviK1MYD0WX8Mc7EUp1KmxEC/oJeOKy/Z0uUP3Fpo2z3ZIDqnqTnyR 1LswhwHg31pE8bxtWvPWW7wk8GJTtvMbkqSoH86I9dbmxCGoSSnmLPAT2x/XTPL6qxy5 bURKd+q1UWl8lOjHI1v74OaKnVBmEEdW6TSSYidpcs+lLwucquvbay1OzUND88322lTQ p2hbeuQuTlwzGSGRBKB14qPw34GcIBb3ourwhck6NxJPtxFRIvOWiX0YsiaPp8BG7Z38 RR7w==
I understand this would ease the life of debian users (and maybe some
other distribs), but the fact that superlu headers are in a superlu/
folder is not standard.
btw, in the devel branch we have a built-in SparseLU solver making the
SuperLU wrapper quite obsolete.
On Sun, Feb 17, 2013 at 6:24 PM, Jan van Dijk <jan@xxxxxxxxxxxxxxxxxx> wrote:
> Dear all,
> I recently noticed that the SuperLU solver wrappers include the required
> super-LU includes without using the superlu/ directory prefix: in the file
> Eigen/SuperLUSupport we have:
> #include <slu_Cnames.h>
> #include <supermatrix.h>
> #include <slu_util.h>
> In the case of supermatrix.h, that caused the wrong file to be included on my
> local setup.
> Apart from this 'namespace issue', this scheme has the disadvantage that user
> code needs compiler options, like "-I/usr/include/superlu", that would
> otherwise not be needed in most cases.
> I would therefore kindly ask you to consider the attached patch (against
> trunk). It prepends superlu/ to the header names, and instructs cmake to look
> for the directory containing superlu/supermatrix.h instead of supermatrix.h.
> (Being an autotools guy, I have no idea if that CMake part of the patch is all
> that is needed. Please have a look.)
> Thank you for your time,
> with kind regards,
> Jan van Dijk.