Re: [eigen] SuperLU include directories

[Gael Guennebaud <gael.guennebaud@xxxxxxxxx>]

Hi,

I understand this would ease the life of debian users (and maybe some
other distribs), but the fact that superlu headers are in a superlu/
folder is not standard.

btw, in the devel branch we have a built-in SparseLU solver making the
SuperLU wrapper quite obsolete.

gael.

On Sun, Feb 17, 2013 at 6:24 PM, Jan van Dijk <jan@xxxxxxxxxxxxxxxxxx> wrote:
> Dear all,
>
> I recently noticed that the SuperLU solver wrappers include the required
> super-LU includes without using the superlu/ directory prefix: in the file
> Eigen/SuperLUSupport we have:
>
>         #include <slu_Cnames.h>
>         #include <supermatrix.h>
>         #include <slu_util.h>
>
> In the case of supermatrix.h, that caused the wrong file to be included on my
> local setup.
>
> Apart from this 'namespace issue', this scheme has the disadvantage that user
> code needs compiler options, like "-I/usr/include/superlu", that would
> otherwise not be needed in most cases.
>
> I would therefore kindly ask you to consider the attached patch (against
> trunk). It prepends superlu/ to the header names, and instructs cmake to look
> for the directory containing superlu/supermatrix.h instead of supermatrix.h.
> (Being an autotools guy, I have no idea if that CMake part of the patch is all
> that is needed. Please have a look.)
>
> Thank you for your time,
>
> with kind regards,
>
> Jan van Dijk.
>