| Re: [eigen] Patch to AlignedBox |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Patch to AlignedBox
- From: Gael Guennebaud <gael.guennebaud@xxxxxxxxx>
- Date: Wed, 10 Oct 2012 22:02:21 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; bh=Y0jJvBDS0VvzlVnFDUsAaWLDUjdqY0o4BDmgeDAQ9Jo=; b=U3TRfkggN1f8erNUN5KYoFqQeIlGZuHkOm4BIuA+YvRylM1WldcUxPU7zQdyL5KCWf YSoS8h/Y/F/VyWm9mPc/IrZt2GtNxX7siNVMKLchq82XvbRPzYIBJ4G/XS4aHyB9tAOe PjGWyd+PcKwaV5up/Va+v8COSJTBfAdorR1/68f7GAKjo0XrghKx++OicfFkTbQNOjZA 8xqqejapPbgw97C/AP7cvLXeHh+h8zvvG3FWWwnbH4MwDX+si+bLoCA9IEzntRHa/6K5 hm1MEcDOIsdmFYSJ+5HmL+VNdT+EWR2hllwyQrM+z34BqEdfxBxI6a0cVPIyaVeDPG6j 7R2w==
Hi,
what's the use case for "expand"? (I think "scale" would be less
misleading since we already have a "extend" function with a totally
different behavior)
Regarding CornerMatrixType I think it should be a fixed size matrix
instead of a dynamic one.
Finally, regarding the new names, I'd rather sort the words in X, Y, Z
order, what do you think?
cheers,
gael
On Fri, Sep 28, 2012 at 3:51 PM, Wood, Tobias <tobias.wood@xxxxxxxxx> wrote:
> Dear list,
> I've recently converted all the maths in an OpenGL 3D viewing app I wrote to Eigen, and it's working really well. I was very happy when I came across the AlignedBox class, as it matched pretty well to some code I'd already written. However, it was missing two bits of functionality I really needed:
> 1) A convenient way to get all the corners of the bounding box in a Matrix, in an order consistent with CornerType.
> 2) A way to expand or contract the bounding box along each axis independently.
> I've attached a patch that adds this functionality to AlignedBox. I have no idea whether this would be useful to anyone else, or whether I've coded it up in a particularly good way.
>
> I also took the liberty of adding some extra names to the CornerType enum that would go some way to fixing bug 476 (But without marking the old names as deprecated, because I don't know what mechanisms exist in Eigen for such marking). Because I combined the two together in one patch, I thought it would be better to initially send it here rather than Bugzilla.
>
> Best wishes,
> Toby Wood
>