| Re: [eigen] Fix for broken asserts revealed by Clang |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Fix for broken asserts revealed by Clang
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Wed, 18 Jan 2012 19:30:15 -0500
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=81e9ngnKv1z7u/O5zfxfqeOhasi6hN5ba2XZMr4Mir0=; b=JQc+Y3doi6/Hijew/yZomVlFB4nyuBeLyVRX5QJyqvzcnIc/SA62BXQyGt9Ei/yYLS erRZscJ83wvoaCTUh3sDvyj+qaD6Ar/1RQfwElGkxSloqAIONFbDzqCxI6/j7BSfccFW gvZI4tD3KuJqMrjFV9NgkEFla2l/ASHcHo6iU=
Thanks a lot, pushed on default branch (80fd9c3c0975) and 3.0 branch
(0408f7aa42d7).
Benoit
2012/1/18 Keir Mierle <mierle@xxxxxxxxx>:
> The attached mercurial export fixes some broken asserts. It's surprising
> that these ever worked as expected, since the asserts always evaluated to
> true before. Clang forbids converting char pointers to bool, which is what
> triggered this.
>
> Keir