| Re: [eigen] GCC-4.6 compilation problem + patch |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] GCC-4.6 compilation problem + patch
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Thu, 5 May 2011 08:06:13 -0400
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=DK9rJLaWFbiqn5v7Rh90vJ3kG8+gMVERIEuRqt3Fn58=; b=WQjhveFnweLxg1mqvH9p6KHBXgJn+qkBigJ5N7LEqwG1UBTodhnI8CshWngVDyQ5tr r3+Ux047kwcVBkFNrc8fUfvxDp18HMOdOQrXUfEF2YLp009frLP+u7864zNxw6tpwOKR 1bGv+zxa46HJuL7HF8BpUrblwTuRqznptLltk=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=LTizFLHXE/75LjOXXCb6T0TgLVhnfCm2sRlzvvBmCYIzyZ+NpO5pqY4IShkecBm5oh VPF5OHP0BlD7UHIVoQJQeOEgmzK3kNFwSNWyAAgBQZlt8SSzujYR9tGfbsAkKgWSSYvP z0+pDHq8FKacN6l0riVgHtc2dG17/rDqnMsSw=
ptrdiff_t is a very common thing to use so I doubt that we will think
about adding std:: everytime. I would suggest doing like we do for
size_t, that is (in Eigen/Core i think):
namespace Eigen {
using std::ptrdiff_t;
}
2011/5/4 Thomas Capricelli <orzel@xxxxxxxxxxxxxxx>:
>
> Sound good. I've checked here that it still compiles with older gcc and it
> does. I've applied the patch, thanks!
>
> Thomas
>
> --
>
> Thomas Capricelli <orzel@xxxxxxxxxxxxxxx>
>
> http://www.freehackers.org/thomas
>
> On Wednesday 04 May 2011 23:56:39 Anton Gladky wrote:
>
>> Hi, all
>
>>
>
>> First of all, thanks for the great library!
>
>>
>
>> But working on package for Debian (gcc-4.6), I found that "make doc"
>
>> and "make check" are both failed.
>
>> The problem is in using in some places of the code "ptrdiff_t" instead
>
>> of "std::ptrdiff_t".
>
>>
>
>> The patch is attached.
>
>>
>
>> Thank you.
>
>>
>
>> Anton Gladky
>
>>
>