Re: [eigen] Building eigen in non x86/amd64/ppc archs

[ Thread Index | Date Index | More Archives ]

2010/12/27 Thomas Capricelli <orzel@xxxxxxxxxxxxxxx>:
> Yes, definitely. I've checked here (echo|gcc -dM -E -x c -|sort|less) and
> inded __i386__

Yes so you need to do a positive check for either __i386__ or __x86_64__.

Moreover, be very careful that MSVC uses different preprocessor
symbols than other compilers do. Checks that potentially are done with
MSVC need to be aware of that.

In any case, for features that are specific to one or two platforms, a
positive check is much better than a negative check against all other


 is not defined on amd64, so your modification is needed. I'll
> commit in ~24 hours unless something else pops up. Thanks!
> ++
> Thomas
> --
> Thomas Capricelli <orzel@xxxxxxxxxxxxxxx>
> On Monday 27 December 2010 22:08:08 Jose Luis Blanco wrote:
>> Yes, a list of positive checks is clearly a better solution.
>> But, wouldn't amd64 be also included (it seems __i386__ is not defined
>> in amd64 archs)??  [1]

Mail converted by MHonArc 2.6.19+