Re: [eigen] Incorrect result of multiplication with scalar (mingw gcc 4.5 x64)

[ Thread Index | Date Index | More lists.tuxfamily.org/eigen Archives ]


ok thank you,

I've just pushed the patch

gael

On Thu, Sep 2, 2010 at 10:59 AM, Eamon Nerbonne
<eamon.nerbonne@xxxxxxxxx> wrote:
> I added a comment explaining why intrin.h is included.  Since intrin..h is
> included as part of windows.h, this patch shouldn't break things even in the
> unlikely event that mingw does eventually fix the bug.
>
> Thanks for the reminder about the comments - this is indeed exactly the kind
> of code that makes no sense whatsoever on its own :-)!
>
> --eamon@xxxxxxxxxxxx - Tel#:+31-6-15142163
>
>
> On Tue, Aug 31, 2010 at 17:08, Thomas Capricelli <orzel@xxxxxxxxxxxxxxx>
> wrote:
>>
>> Thanks for the patch. I dont use mingw so can't test, i'll let others
>> include it.
>>
>> Typically for such a conditional include, I would add a one-line comment
>> explaining that it fixes an issue with mingw.
>>
>> regards,
>>
>> --
>>
>> Thomas Capricelli <orzel@xxxxxxxxxxxxxxx>
>>
>> http://www.freehackers.org/thomas
>>
>> On Tuesday 31 August 2010 15:18:18 Eamon Nerbonne wrote:
>>
>> > Obviously, this is a mingw bug, but sure, the attached patch works
>> > around it by including intrin.h right before the other intrinsics files on
>> > mingw.
>



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/