Re: [eigen] Fix for precedence bug in SparseLU.h on 2.0 branch

[Benoit Jacob <jacob.benoit.1@xxxxxxxxx>]

Thanks a lot! Very good warning indeed. So, it appears that you were referring to the 2.0 branch.

Committed under the name DJ Marcin because that sounded too cool to let pass.
Next time you can do hg commit and hg export so you can write your name and commit message.

Benoit

2010/8/23 Keir Mierle <mierle@xxxxxxxxx>

Found by your friendly neighbourhood clang compiler:

./eigen/Eigen/src/Sparse/SparseLU.h:99:7: error: & has lower precedence than ==; == will be evaluated first [-Wparentheses] 

ei_assert(m&~OrderingMask == 0 && m!=0 && "invalid ordering method"); 

^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Keir