| Re: [eigen] Eigen2: Assert failure in QR |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Eigen2: Assert failure in QR
- From: Gael Guennebaud <gael.guennebaud@xxxxxxxxx>
- Date: Thu, 15 Jul 2010 22:54:21 +0200
- Cc: Nick Lewycky <nlewycky@xxxxxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=+sDk45v+KM+X8zbICpHNZJ3NzRMHpnSgx7/6T9P0GHk=; b=dbf6lbRcCU91V2wAFKR5E+8fsFy+Yn0fAuzotVQED0ceF1epX/qRHlzMh8dc5ZCWm7 0FECi8iKCi4WgBRzyTHTCM2LUyu+rsdW1UUczdQNEEzrhy34PRVhdQbT6z4J4yUWzbRZ uX+8HukrtRXZYg33JfZzF//AC1OL3n5clHCVI=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=i890I8oGKX+p2B12ipgDJIMqaPlJrBBpfDUN41eq9qvs2aMhe9mF8upfBkRuot4LFa HNV/Pj0pYrn3qySe7/zMr+f4oHswFhNjeDaAyOpIgsMGO3oBZ91zfqGzqR/NVf1spL2H yVCawR8288ygZoNQ/lrYbS/cFHVoTVPOg9wUw=
hi,
thanks for the patch. It seems it has been made on an older version,
so I had to apply the changes manually but that's fine.
if someone having clang could give it a try because there have been a
couple changes between the version you used to make that patch and the
current 2.0 branch.
now compiling with 3.3...
gael
On Thu, Jul 15, 2010 at 10:35 PM, Keir Mierle <mierle@xxxxxxxxx> wrote:
> This patch is due to Nick Lewycky.
> Fix C++ conformance problems in stable eigen; discovered by clang.
> * the 'template' keyword is required when the type is dependent on a
> template argument. With 'template' we treat the next identifier as
> a template method instead of a member variable and less-than
> operator.
> * ei_cache_friendly_product was never actually static. Remove the
> bogus 'static' keyword. (Adding it properly caused link errors.)
> * sink the definition of template function ei_hypot after the
> declarations of the functions it tries to call.
> Clang warns on default template argument
> int StorageOrder = (unsigned)-1
> so cast the whole RHS as int which appears to have been the intent.
> Keir
> On Thu, Jul 15, 2010 at 11:18 AM, Keir Mierle <mierle@xxxxxxxxx> wrote:
>>
>> I have another set of patches for Clang compatibility we should add before
>> 2.0.15.
>> Give me a few minutes to send it in.
>> Keir
>>
>> On Thu, Jul 15, 2010 at 11:13 AM, Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
>> wrote:
>>>
>>> Time to release 2.0.15 ? There's been one other important fix.
>>>
>>> As soon as someone confirms gcc 3.3 and msvc, i'm OK to release.
>>>
>>> The flurry of 2.0 fixes in the past 2 months is rather impressive, i
>>> guess it means that the number of users increased...
>>>
>>> Benoit
>>>
>>> 2010/7/15 Gael Guennebaud <gael.guennebaud@xxxxxxxxx>:
>>> > oh, we probably fixed the bug at the very same time ;)
>>> >
>>> > indeed, it scary to have such a bug, fortunately unit test in 3.0 are
>>> > much better ;)
>>> >
>>> > gael
>>> >
>>> > On Thu, Jul 15, 2010 at 7:58 PM, Keir Mierle <mierle@xxxxxxxxx> wrote:
>>> >> Fix attached. How did this ever work before?
>>> >> Keir
>>> >>
>>> >> On Thu, Jul 15, 2010 at 9:55 AM, Sameer Agarwal
>>> >> <sameeragarwal@xxxxxxxxxx>
>>> >> wrote:
>>> >>>
>>> >>> Hi Guys,
>>> >>> Maps and QR in Eigen2 triggers an assert error, depending on whether
>>> >>> -DNDEBUG is used or not.
>>> >>>
>>> >>> eigen# g++ qr_test.cc -o qr1
>>> >>>
>>> >>> eigen# ./qr1
>>> >>> Assertion failed: (rows == this->rows()), function resize, file
>>> >>> Eigen/src/Core/Map.h, line 84.
>>> >>> Abort trap
>>> >>>
>>> >>> eigen# g++ qr_test.cc -DNDEBUG -o qr2
>>> >>> eigen# ./qr2
>>> >>>
>>> >>> This is against Eigen 2.0.14.
>>> >>> Sameer
>>> >>
>>> >>
>>> >
>>> >
>>> >
>>>
>>>
>>
>
>