|Re: [eigen] [patch] LDLt decomposition with rank-deficient matrices|
[ Thread Index |
| More lists.tuxfamily.org/eigen Archives
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] [patch] LDLt decomposition with rank-deficient matrices
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Sat, 26 Jun 2010 14:05:26 -0400
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type; bh=+btWXxyQT26Y3ods8r0i2dQD9ajSLHkQRa8cml2yOQM=; b=ul8DOwirbLvf0nOBzuYsMi/KnGcYoWuK5CgQi7A7ziNnyn0iNTg8Rut5rTr/nDX3Uc JLQUFxSRDDWCE2plQnPv5D/icH8Fz2sVAbfUUGuXmgzPCM57AITYdhnLgQURcb6BKIkI FMpoooQyNdci1C0Wwju7z4jQoPboGERhfVnSc=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=bHixBaTuhwEYBBod25JymGTcgGCTMUQyxIwTjkUyYVzGcmR71s02PhsEbkXeI/QphK wy5wxwUD+bxUm+H6pbQPw/ubGklakDMn55L7v0RXF2i12qIJsgYDxzP6cCMGIVzOTLkR KiDtDlEUJmVe61LAqveJiOe4YRi1UYwgFvHfA=
Thanks for the patches and sorry that I don't have time to look at
them today: we are currently in an incredible rush to get beta1 out
the door, and that means a lot of documentation work. I think that
your stuff is OK to apply post-beta1 anyway. Just wanted to let you
know why we might have long response times these days.
2010/6/26 Ben Goodrich <bgokgm@xxxxxxxxxxxxxx>:
> On Fri, Jun 25, 2010 at 1:50 AM, Ben Goodrich <bgokgm@xxxxxxxxxxxxxx> wrote:
>>>> 5) I copied-and-pasted a block inside /test/cholesky.cpp and exercised
>>>> the pivot=false option. It seems to work when you do ./check.sh
>>>> cholesky. I did some other tests locally with singular matrices, but
>>>> /test/cholesky.cpp does not seem to have any tests with singular
>>>> matrices, so maybe some should be added?
>>> why not.
>> I have not added the singular tests yet, but I can do that soon.
> This patch does so. It seems to work okay with both the Pivoting and
> NoPivoting options from the previous patch.
>>> You should also make the solve function skips the transpositions when
>>> no pivoting has been computed.
>> I have not done this yet either. What did you decide about making a
>> new class versus putting a flag in the class definition?