Re: [eigen] QR VS2008 compilation error

[Gael Guennebaud <gael.guennebaud@xxxxxxxxx>]

thank you, pushed.

gael

On Fri, May 28, 2010 at 10:20 AM, Anton Gladky <gladky.anton@xxxxxxxxx> wrote:

Hi,

the patch is in attachment.
______________________________

Anton Gladky

2010/5/27 Benoit Jacob <jacob.benoit.1@xxxxxxxxx>

right, good catch. can somebody fix it? or can you make a patch? i'm
at work now.

http://eigen.tuxfamily.org/index.php?title=Developer's_Corner#Generating_a_patch

Benoit

2010/5/27 SHIROKOBROD Oleg <Oleg.Shirokobrod@xxxxxxxxxx>:

> Hello,
>
>
>
> MSVS 2008 issues an error message “Function should return a value” in
> functions
>
>
>
>
>
> ColPivHouseholderQR& ColPivHouseholderQR::setThreshold(const RealScalar&
> threshold)
>
>     {
>
>       m_usePrescribedThreshold = true;
>
>       m_prescribedThreshold = threshold;
>
>     }
>
> ColPivHouseholderQR& ColPivHouseholderQR::setThreshold(Default_t)
>
>     {
>
>       m_usePrescribedThreshold = false;
>
>     }
>
>
>
> In the file Eigen\src\QR\ ColPivHouseholderQR.h
>
>
>
> I guess they should return selfreference:
>
>
>
> ColPivHouseholderQR& ColPivHouseholderQR::setThreshold(const RealScalar&
> threshold)
>
>     {
>
>       m_usePrescribedThreshold = true;
>
>       m_prescribedThreshold = threshold;
>
>       return *this;
>
>     }
>
> ColPivHouseholderQR& ColPivHouseholderQR::setThreshold(Default_t)
>
>     {
>
>       m_usePrescribedThreshold = false;
>
>       return *this;
>
>     }
>
>
>
>
>
> Thanks,
>
>
>
> Oleg Shirokobrod
>
>
>
>
>
> ___________________________________________________________________________
> This e-mail is confidential and is for the addressee only.   Please refer to
> www.oxinst.com/email-statement for regulatory information.