| Re: [eigen] NEON remaining failing tests |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
On Thursday 04 March 2010 15:43:21 Benoit Jacob wrote:
> Hi,
>
> Some comments on some of these.
>
> if some platforms can't vectorize integer division, we should provide
> a way for them to say it and use a scalar path.
>
> It's pretty simple actually. integer division is going to be
> implemented somewhere as a functor in Functors.h. It's probably called
> ei_scalar_div_op or ei_scalar_quotient_op... there, at the place where
> we say that it has packet access, you just have to add a #ifndef
> ARM_NEON... same for AltiVec by the way.
and SSE, right now no SIMD engine provides a way to do integer division.
> > ./geo_quaternion_1
> > Initializing random number generator with seed 1267698439
> > Repeating each test 10 times
> > geo_quaternion_1: /home/oem/eigen/Eigen/src/Core/MapBase.h:152: void
> > Eigen::MapBase<Derived, Base>::checkSanity() const [with Derived =
> > Eigen::Map<Eigen::Matrix<float, 4, 1, 0, 4, 1>, 1, Eigen::Stride<0, 0> >,
> > Base = Eigen::MatrixBase<Eigen::Map<Eigen::Matrix<float, 4, 1, 0, 4, 1>,
> > 1, Eigen::Stride<0, 0> > >]: Assertion `((!
> > (ei_traits<Derived>::Flags&AlignedBit)) || ((size_t(m_data)&0xf)==0)) &&
> > "data is not aligned"' failed.
> > Aborted
>
> Forgot about this assertion, indeed at MapBase.h:152. Enclose it in a
> platform #ifdef and write a big FIXME comment.
Ok, will do.
> > ./product_large_1
> > Initializing random number generator with seed 1267698875
> > Repeating each test 10 times
> > Test product(MatrixXf(ei_random<int>(1,320), ei_random<int>(1,320)))
> > failed in "/home/oem/eigen/test/product.h" (134)
> > test_ei_isApprox(tm1.transpose() * v1, m1.transpose() * v1)
>
> Yes, fix this one first. No idea why it's failing though :/
Ok, I'll put some debug statements to see what it actually produces and get
back to you on that one.
Konstantinos