| Re: [eigen] Re: BenchTimer: small patch to avoid compiler warnings and add missing include |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Re: BenchTimer: small patch to avoid compiler warnings and add missing include
- From: Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>
- Date: Tue, 2 Mar 2010 16:54:23 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=k5SBBkMcIPGa/Pt8CPilTDxCAela4NBfpUL4tO3C+Sc=; b=ksFfDKUZ4FK2bCIIHK4o0UgDpCOkE3hQVLRbYenuv3vOA7tle3JZeBpe5kZDKRdUGw Nq7xJE8jrb2i+fTNZgSHOPx/ZtOJODeKdlxFsTCP03CfL4xjZG2LRCPWzAwW9B/uE1zq KisfEoXWxr2DTvxFsNUXW9IkhDRWsLp4Tr9Mg=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=CsuQv2N+k7rYo5qDx+ZAjMCWFYdamINlNelIhh0ZWpNbSWtU1yN93OosKCJH3Z4cSy yKyQn453BnH36KTf50+gPpH947p2uh5zsNgPqQpBq05KfFH1sW/tEC8HfP6QlEEzljoI /Wjr9wbcfpXuR2B2QeOcnpPdmyNo5tP74531Y=
It arrived...
On Tue, Mar 2, 2010 at 4:51 PM, Eamon Nerbonne <emn13@xxxxxxxxxxxx> wrote:
> Can anybody confirm they actually received this? I'm a little confused
> about whether this email address is a member of the list or not, at the
> moment.
>
> --eamon@xxxxxxxxxxxx - Tel#:+31-6-15142163
>
>
> On Tue, Mar 2, 2010 at 15:25, Eamon Nerbonne <emn13@xxxxxxxxxxxx> wrote:
>>
>> I get the impression the previous mail never arrived. There seems to be
>> something slightly odd going on with listmaster; it claims I'm subscribed
>> with my normally primary email address eamon[at]..., but won't let me
>> unsubscribe nor post. On the other hand, sending from this email address
>> works.
>>
>> In any case; the patch...
>>
>>
>> --eamon@xxxxxxxxxxxx - Tel#:+31-6-15142163
>>
>>
>> ---------- Forwarded message ----------
>> From: Eamon Nerbonne <eamon@xxxxxxxxxxxx>
>> Date: Tue, Mar 2, 2010 at 09:21
>> Subject: BenchTimer: small patch to avoid compiler warnings and add
>> missing include
>> To: eigen@xxxxxxxxxxxxxxxxxxx
>>
>>
>> Hi everyone,
>>
>> In the process of looking for a few perf. regressions, I came across two
>> minor issues in BenchTimer.h:
>> - in windows, it defines the NOMINMAX and WIN32_LEAN_AND_MEAN. Those are
>> common preprocessor symbols and may already be defined. To avoid warnings
>> in gcc on windows, I wrapped them in an #ifndef.
>> - BenchTimer uses Vector2d but doesn't include Eigen/Core; so if you
>> include BenchTimer before Eigen/Core (or without it), it won't compile. I
>> added the appropriate include.
>>
>> It also turns out gcc on windows throws a fit if you try to include
>> Eigen/Core before BenchTimer.h; I'm not sure that's worth fixing (or even
>> how to). What happens is that it complains about the various sse
>> intrinsics; these are obviously being included by eigen, but they're also
>> included by windows.h via BenchTimer. However, windows.h includes windef,
>> which in turn has an extern "C" section that includes the intrinsics. GCC
>> then complains that this new definition uses "C" linkage rather than the
>> previous C++ linkage, eg:
>>
>>
>> c:\gcc\equation443\bin\../lib/gcc/x86_64-pc-mingw32/4.4.3/include/emmintrin.h:234:
>> error: previous declaration of 'double __vector__ _mm_add_sd(double
>> __vector__, double __vector__)' with 'C++' linkage
>>
>> c:\gcc\equation443\bin\../lib/gcc/x86_64-pc-mingw32/4.4.3/../../../../x86_64-pc-mingw32/include/intrin.h:599:
>> error: conflicts with new declaration with 'C' linkage
>>
>>
>>
>> --eamon@xxxxxxxxxxxx - Tel#:+31-6-15142163
>>
>
>