Re: [eigen] Eigen3 ->Eigen2 performance regression: patch.

[ Thread Index | Date Index | More lists.tuxfamily.org/eigen Archives ]


Applied and thank you a lot for your help - its highly appreciated!

- Hauke

On Fri, Feb 26, 2010 at 6:27 PM, Eamon Nerbonne <emn13@xxxxxxxxxxxx> wrote:
> As mentioned in the forums
> (http://forum.kde.org/viewtopic.php?f=74&t=85488&sid=56568a50ee5f70d17993d387dedd9c63&start=30#p149344)
> on microsoft's compiler there's a performance regression in eigen3
> concerning subtraction of VectorXd's (and probably other matrices with other
> cheap operations too).  The appropriate ei_assign_impl isn't always inlined,
> and since the operation is otherwise cheap; the function call overhead is
> quite significant.  Gcc seems to inline the function; but MSC does not when
> vectorization is on (EIGEN_DONT_VECTORIZE not defined).  Replacing the
> "inline" keyword with the EIGEN_STRONG_INLINE macro resolves the problem.
> Attached: patch.
> --eamon@xxxxxxxxxxxx - Tel#:+31-6-15142163



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/