| Re: [eigen] Eigen3 ->Eigen2 performance regression: patch. |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Eigen3 ->Eigen2 performance regression: patch.
- From: Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>
- Date: Fri, 26 Feb 2010 19:47:57 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=KqvLdJTsdFMz84IFqvAN6/xC6RddQ7A/R2y8wSLZ6Ms=; b=TESckmMTyDN7MBKOD0MZGfoykhYjrM9C/0z+1HSqzFVVhHGVoncXzyAhG9lIVW/kO3 JyopIDb+xrngbe/KvP5s7FC7ZZLWt27u6xgSJ2SNB7kJVrkO5WYMfFfn/gmnwcmWwEuP p5Vb3NxLiy4uo9eKjudWlsBup+tXCGbiDq1Wg=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=OYxl2F31224OE6JXGnvRe6Ll487vgPbHA9jTNZse3WwnnsQorWzSBbhet2KAvzsp9F eCRw2qYgnW0s3eOi2yMFPFrIs+mZIbagfHk5LiW243aXQBF5vBrmh2k24ywLvTvEzq6x LvIpaLl69kqayD9VYp1TYb46q6idBm7emsJtM=
Applied and thank you a lot for your help - its highly appreciated!
- Hauke
On Fri, Feb 26, 2010 at 6:27 PM, Eamon Nerbonne <emn13@xxxxxxxxxxxx> wrote:
> As mentioned in the forums
> (http://forum.kde.org/viewtopic.php?f=74&t=85488&sid=56568a50ee5f70d17993d387dedd9c63&start=30#p149344)
> on microsoft's compiler there's a performance regression in eigen3
> concerning subtraction of VectorXd's (and probably other matrices with other
> cheap operations too). The appropriate ei_assign_impl isn't always inlined,
> and since the operation is otherwise cheap; the function call overhead is
> quite significant. Gcc seems to inline the function; but MSC does not when
> vectorization is on (EIGEN_DONT_VECTORIZE not defined). Replacing the
> "inline" keyword with the EIGEN_STRONG_INLINE macro resolves the problem.
> Attached: patch.
> --eamon@xxxxxxxxxxxx - Tel#:+31-6-15142163