| [eigen] Disable variadic macro warning when compiling at full warning level. |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: Eigen <eigen@xxxxxxxxxxxxxxxxxxx>
- Subject: [eigen] Disable variadic macro warning when compiling at full warning level.
- From: Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>
- Date: Fri, 29 Jan 2010 13:37:04 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=iLs8R3hEhXjzvzFTuTR2639bexVDRJ4dB0Uj/XW2sdQ=; b=ZTQO8uV5rbT1F0pOKDrj0PGgkMYGEUbRkmcWfLtloy98Et1hOTTmJZ+0sc44ihYuOX 3gEzTjJ3t580aXYdRlDRY2kGWv20UUVB7afC2sqUgulOpJo8TN5ZS5KIOAHGjrGiPEVy HrYFrvm2OlA3wV70FF6OzJ78LczR632+8aFcM=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=q8R0AkswBdzXVi+8SAUePyAYe4ho1EOBFE9/Jfcf2VImzqhpFAExmcDU036cYt5aUc 2Uvcev0aH4Fiw4Gfz3+zADB6OWcjkFgV2eJbwfcMP3WfXitl5YJSIC9bHfWnhIAYxyfZ gc1qXcw3+83yZqOfm2PGHRKPal8tr7SqulwUc=
I tried, but was not able to do so.
I tried the following pragma directive
#pragma GCC diagnostic ignored "-Wno-variadic-macros"
but the compiler did not accept it and gave me warnings about it.
Maybe you are right and I should backout the commit.
What bothers me is that CTest/CDash has a warning limit of 50 and with
EIGEN_TEST_MAX_WARNING_LEVEL enabled the warnings regarding the
variadic macros are hiding potentially interesting ones.
Maybe somebody else has an idea and maybe I am using the GCC pragma
the wrong way.
- Hauke
On Fri, Jan 29, 2010 at 12:45 PM, Benoit Jacob <jacob.benoit.1@xxxxxxxxx> wrote:
> I don't understand this commit. It has the effect of hiding a warning
> from us when we build the unit tests, but it won't hide the warning
> from our users when they build their own application using Eigen.
> Hence we're going to get users confused about this warning, right?
>
> If you need this warning disabled, we need to disable and re-enable it
> with pragmas in eigen itself.
>
> 2010/1/29 <commits-noreply@xxxxxxxxxxxxx>:
>> 1 new changeset in eigen:
>>
>> http://www.bitbucket.org/eigen/eigen/changeset/e827151721cb/
>> changeset: r2403:e827151721cb
>> user: hauke
>> date: 2010-01-29 09:53:19
>> summary: Disable variadic macro warning when compiling at full warning level.
>> I was not able to get a macro version running and thus I opted for a cmake patch.
>> affected #: 1 file (230 bytes)
>>
>> Repository URL: http://bitbucket.org/eigen/eigen/