|Re: [eigen] MSVC inlining - just FYI|
[ Thread Index |
| More lists.tuxfamily.org/eigen Archives
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] MSVC inlining - just FYI
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Thu, 17 Dec 2009 09:15:15 -0500
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=amm4QFXhW/vFIHLn8P22PDTWXrpcnH+rtKNApte9ueA=; b=fpw5pjY2HRlLfzreWqlq4CprAOI8LWJB/tEvAGpIzv1RbUcP4rCIpbC8EYIKdmid6z 7D7IVh0cPKC8nslNomFzqP68XYtlNtHVPJQ1nLn9oVX4QmAZcOXnZ6BEBKLxutC7hhJ/ aGn4In6SYzKTuICivgKisR050Ql/0nPMla4r0=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=ahvB+XJllRqmWPiSqwYGM80/DKf4u4DvnHQfhYxg8uwQ29TBoG0KLT+JrEXIHGuBwA Xxn04jRWzJcbkVwaAwYTBGh+m+Nbkj2nIc7d955baV7TzQHbHg0SY7WRETvxuItT/8Av H6fu+tQM9xz8RVvXBZP3u9ezUHGc9OtKv8e7U=
How about adding this MSVC warning to DisableMSVCWarnings.h at least
by default; if you want you can add a preprocessor option to keep it
and a CMake option to enable that in the unit tests.
After all, there are many reasons that may prevent a compiler from
inlining a function, and they don't usually emit warnings about that.
2009/12/17 Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>:
> Hi all,
> So, after some reading I was able to find out the following things I'ld
> quickly like to share.
> There was a recent discussion regarding the inlining problem on
> The problem which is affecting us is that MSVC does not inline functions
> returning an unwindable object (an object having a non-trivial destructor or
> an object having members with non-trivial destructors). Here is an example
> where the __forceinline is ignored unless exception handling is disabled.
> template <typename T>
> struct UnwindableTemplate
> T* m_data;
> UnwindableTemplate() : m_data(0)
> delete  m_data;
> template <typename T>
> __forceinline UnwindableTemplate<T> create_unwindable()
> return UnwindableTemplate<T>();
> void main ()
> UnwindableTemplate<float> unwind = create_unwindable<float>();
> Here, I choose the unwindable object to mimik our ei_matrix_storage classes
> for the particular case when we are dealing with dynamic sized objects. As a
> consequence, this leads to the fact that functions returning expressions
> containing matrix members by value will not be inlined. Currently it seems
> as if this can not be remedied. Returning a reference to a local temporary
> seems tempting since we are anyways trying to enforce inlining but I would
> refrain from such a solution and say we just live with it.
> It seems as if with newer compiler versions the SSE issue mentioned in the
> forum is fixed and not our actual problem.