Re: [eigen] GivensQR |

[ Thread Index | Date Index | More lists.tuxfamily.org/eigen Archives ]

*To*: eigen@xxxxxxxxxxxxxxxxxxx*Subject*: Re: [eigen] GivensQR*From*: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>*Date*: Wed, 9 Sep 2009 17:25:59 -0400*Dkim-signature*: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=5D4ofE0oeYaPrCMEsnCMcZCDDAOViptpjJvKcvaz9jk=; b=IHziOJ5/ehNh8vBoMUW2HxQdWfka/Lq9ntVQXf4PvpO3gzl2cFw3yStgf1ksFoBjk0 4EXLqsRzVLEY6A+NidNGU5yhIiukMgyDLtLo+dGybJ162aaW5I2nqOlMo7Ii8oTwlMlX PWwyyXZ5PSIlfI7JDGYNXvNS2g8C3AM3hRzFI=*Domainkey-signature*: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=Owd4XzYT2OgoDt8hOO6N4zcZ4eW0BM+xCpnfFMekB0XFfIO31htFUoMFegNFNMZr1T JHuWvIDL0CLKYcbhQGMf9hNWoI4NDUKZnE90JIQxQdNQNzy3zqytZucTEQer9KkcW/Lg JnOqpaTDX5cAQ3NHdBvsl9LpJmpQSbGsZEqVU=

2009/9/8 Andrea Arteaga <yo.eres@xxxxxxxxx>: > In principle my Givens decomposition was designed for small-sized square (or > quasi-square) matrices. Your benchmarks show that this kind of decomposition > is actually not optimal for big matrices, due to the algorithm's limits. I > think however that this decomposition could be faster as Householder if the > code were a little optimized. We can begin that by using the Jacobi module. ok, I just did that porting. it needs profiling. I'm using Gael's new makeGivens function which while very safe, might incur some overhead. in any case from now it'll be a breeze to adjust. In the process I've lost a tiny optimization that you made, where o1 and o2 were computed in-place to avoid the copy. We can get that back if we decide that m_C becomes an array of PlanarRotation's. But anyway, I highly doubt that it makes any performance difference, because that spares 2 float copies that are dwarfed by the cost of the rest. one thing that bugs me is how you copy the matrices Q and R to "reduced" matrices, and store both reduced and full matrices. It's very unlikely that the user might need both, and even if he did, he would only need the full matrix and would deduce the reduced matrix from it. Benoit

**Follow-Ups**:**Re: [eigen] GivensQR***From:*Benoit Jacob

**References**:**Re: [eigen] GivensQR***From:*Benoit Jacob

**Re: [eigen] GivensQR***From:*Andrea Arteaga

**Messages sorted by:**[ date | thread ]- Prev by Date:
**Re: [eigen] How far along is the sparse module?** - Next by Date:
**Re: [eigen] GivensQR** - Previous by thread:
**Re: [eigen] GivensQR** - Next by thread:
**Re: [eigen] GivensQR**

Mail converted by MHonArc 2.6.19+ | http://listengine.tuxfamily.org/ |