Re: [eigen] MappedSparseMatrix.coeff() uses RowMajor but shouldn't it be IsRowMajor

[ Thread Index | Date Index | More lists.tuxfamily.org/eigen Archives ]


Makes me think we should run tests also on row-major matrices.
It's nontrivial though, the tests already take forever to build.

2009/5/11, Gael Guennebaud <gael.guennebaud@xxxxxxxxx>:
> thanks, patch applied.
>
> Gael.
>
> On Mon, May 11, 2009 at 12:33 PM, Jens Mueller <jens.k.mueller@xxxxxx>
> wrote:
>> Hi,
>>
>> in MappedSparseMatrix there is a bug when accessing the coefficients.
>> RowMajor is used to determine the storage order but RowMajor is
>> constant. I think using IsRowMajor was intended.
>> I'm attaching a small program that will fail and a diff against the
>> current trunk.
>>
>> Regards,
>> Jens
>>
>
>
>



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/