Re: [eigen] Re: [PATCH] Reverse expression (trying again)

[Gael Guennebaud <gael.guennebaud@xxxxxxxxx>]

Hi,

thanks for the patches. I applied them with some minor modifications:
 - move Reverse to the Array module
 - update the computation of the flags:
    * remove: LinearAccessBit, PacketAccessBit, AlignedAccessBit, etc.
    * keep the original storage order (to my understanding the storage
order does not change)
 - I commented part which should not be currently used (packet functions)

Since the Reverse expression cannot have the LinearAccessBit flags,
the index based coeff*(int) functions will be called on vector
expressions only, and so they can be significantly simplified.

gael

On Thu, Feb 5, 2009 at 8:48 PM, Ricard Marxer Piñón
<email@xxxxxxxxxxxxxxxx> wrote:
> Ok here is part 2.
>
> I tried to tackle the index based coeff, coeffRef, packet and writePacket..
>
> I'm not sure it is right, please review it.
>
> I have also made a small change to the doc snippet of PartialRedux.
>
> Let me know if I'm on the right track.
>
> ricard
>
> On Thu, Feb 5, 2009 at 3:35 PM, Ricard Marxer Piñón <email@xxxxxxxxxxxxxxxx>
> wrote:
>>
>> Hi again,
>>
>> This time I think I've got it right.  Or at least righter.
>>
>> I have added tests and as Gael suggested I have added a template parameter
>> to Reverse so that PartialRedux returns an expression (however I still don't
>> know if I've got that part right).
>>
>> In the tests there is one commented part, which I would like to pass in
>> the future but I think it is a bit more complicated.
>>
>> The patch as been generated using git:
>> git format-patch git-svn
>>
>> So to apply to svn it you will need to do (I think):
>> patch -p1 -i 0001-adding-Reverse.patch
>>
>> The coeff(int index) and coeffRef(int index) are still not handled
>> (reversed).  That will come in the next patch.
>>
>> Ricard
>>
>> --
>> ricard
>> http://www.ricardmarxer.com
>> http://www.caligraft.com
>
>
>
> --
> ricard
> http://www.ricardmarxer.com
> http://www.caligraft.com
>