Re: [eigen] [PATCH] ParialRedux count()

[ Thread Index | Date Index | More Archives ]


thanks a lot, I adapted a bit your patch (rev 916097), no need to have
a second EIGEN_MEMBER_FUNCTOR_RETURNTYPE macro. About the cost of
cast, here I assume it is zero because in 99% cases count is applied
on a matrix of bool, and casting a bool to a 0/1 integer cost nothing
(at least currently).


On Sat, Jan 24, 2009 at 1:27 PM, Ricard Marxer Piñón
<email@xxxxxxxxxxxxxxxx> wrote:
> Hi,
> I have added count() to PartialRedux.  Attached is the patch which also
> includes a snippet for the doc.
> When telling the cost of the operator I have simplified a bit and implied
> that the casts to bool and int (which are in the count() method in
> BooleanRedux.h) are always necessary, I think this needs reviews.
> PS: if you think of other easy tasks i could tackle, I would be happy to do
> it, that way I will get more familiarized with Eigen internals.
> --
> ricard

Mail converted by MHonArc 2.6.19+