| Re: [eigen] two technical points: WithAlignedOperatorNew and std::complex casting |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] two technical points: WithAlignedOperatorNew and std::complex casting
- From: "Benoit Jacob" <jacob.benoit.1@xxxxxxxxx>
- Date: Wed, 31 Dec 2008 18:30:06 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=FV3ypZNET2v+Uxc8xOah8xLRWxiGbmVckEsNQEDpjyI=; b=XbvLO8t+eAJnN5R0/Zxp/2rsC0g1sDRjOSef+kBlO2Q2KWMtuGq63QpWDJwnQEa70S YawU8H0DEh9Gi63oz6YYZbMqOSzHfcgNKjeQemXbszeWZB8L9CRm8AGHFRRrPL8lrQXd bba+2+QtzX0Rv8RZe0n5OvwY9Izm/QMq5fSgw=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=woGIX4Owalr+AfZQczG65H0IEgVFuke0SG5BRJ21A0biA7mOH3QGADI4TtP3Sk1pcp KPwTclpfY6h2289o3QdJmd5o8nbyyvzspi/d63o0Hn/IYZxVqJfL3GKWWVEhKQTWExdc hyPXl7mGlYl5qvu4YBOud43MycDBpS70IS2Nk=
2008/12/31 Gael Guennebaud <gael.guennebaud@xxxxxxxxx>:
> yes, my idea was simply to add another enum (eg, since RowMajor==2, it
> could be equal to 2) which would be valid only for the 4th template
> parameter of Matrix, and then we test the presence of this bit to add
> or not the AlignedBit flag in ei_compute_matrix_flag ....
Good idea; the only thing I don't understand is "since RowMajor==2, it
could be equal to 2", maybe you meant "it could be equal to anything
but 2". If we start doing this then we need a static assert to ensure
that the other flags aren't passed as 4th param of Matrix, and we need
to make what we can to prevent confusion between 4th param of Matrix
and the flags -- to begin with, this param should no longer be called
"_Flags", maybe "Options" or "MatrixFlags" would be better.
Cheers,
Benoit
---