Re: [eigen] Bugs in Mat::Random, reductions

["Gael Guennebaud" <gael.guennebaud@xxxxxxxxx>]

On Thu, Oct 23, 2008 at 7:26 PM, Gael Guennebaud
<gael.guennebaud@xxxxxxxxx> wrote:
> So maybe we could mix the 2 approaches. In practice we can define the
> macro EIGEN_ARRAY_ONLY like that:
>
> #ifdef EIGEN_USING_ARRAY_MODULE
> #define EIGEN_ARRAY_ONLY
> #else
> #define you_must_include_array
> struct you_must_include_array{};
> #endif
>
> and declares all "array only" method with:
>
> void someArrayModuleFunc(EIGEN_ARRAY_ONLY);
>
> and for doxygen, we just have to tell it to expand the EIGEN_*_ONLY macros.
>
> then the user will get an explicit error message, and the prototype of
> our function remains clean.
>
> what do you think ? at least if we go for the EIGEN_USING_*_MODULE
> macros, I think the above trick the right way to go. So the question
> is whether everybody is ok with the EIGEN_USING_*_MODULE approach ?
>

Since no one complained, I guess nobody is against that solution. On
the other hand nobody seems to be excited by it, and actually, neither
do I. I mean, currently we have an intuitive mechanism to include
modules, but some weird link error messages if someone forgot to
include the right module.  And the we would change for more intuitive
error messages but with an unintuitive inclusion mechanism. So
eventually that's probably not worth it. In both cases we have to
compensate some unintuitiveness  by big warning in the documentation.
So let's keep the current state, and improve the doc. isn't it ?

gael.

---