Re: [eigen] Sparse Module Patch

[ Thread Index | Date Index | More Archives ]

On Tue, Sep 2, 2008 at 12:56 PM, Daniel Gómez <dgomezferro@xxxxxxxxx> wrote:
> Hello,
> On Monday 01 September 2008 13:22:59 Gael Guennebaud wrote:
>> Hi Daniel,
>> sorry I was not very helpful to guide you with that stuff... actually
>> now I remember what was the big deal  with m.row(i) += xpr; etc....
>> In fact, m.row(i) += xpr; should not be allowed in the general case
>> since this might create new non zero entries...
> But m.row(i) = m.row(i)*4; should be allowed? I think it should, it is easy to
> implement and efficient, although it may confuse users when m.row(i) =
> m.row(j); doesnt work because elements have different indexes.

I see. Then your Block specialization returned by sparse.row(i) could
not inherit MatrixBase and only provides allowed operations like
operator *= (scalar) and operator /= (scalar)

> I attach the current diff. In Core I just changed util/ForwardDeclarations.h
> and util/Constants.h . Be free to change tha naming I used if you think its
> not right. I also changed Block.h to add the declaration of the
> InnerIterator.

looks OK, go ahead.

> I'll be a bit busy until mid-september as I am preparing an exam, by then I'll
> be able to spend a little more time on eigen. By the way, I just received my
> SVN account, so no need to complain to anybody hehe.

good luck !


Mail converted by MHonArc 2.6.19+