[eigen-commits] commit/eigen: 2 new changesets

[ Thread Index | Date Index | More lists.tuxfamily.org/eigen-commits Archives ]


2 new commits in eigen:

https://bitbucket.org/eigen/eigen/commits/c09fc2163723/
Changeset:   c09fc2163723
User:        deven-amd
Date:        2019-10-22 19:21:27+00:00
Summary:     Fix for the HIP build+test errors.

The errors were introduced by this commit :

After the above mentioned commit, some of the tests started failing with the following error


```
Built target cxx11_tensor_reduction
Building HIPCC object unsupported/test/CMakeFiles/cxx11_tensor_reduction_gpu_5.dir/cxx11_tensor_reduction_gpu_5_generated_cxx11_tensor_reduction_gpu.cu.o
In file included from /home/rocm-user/eigen/unsupported/test/cxx11_tensor_reduction_gpu.cu:16:
In file included from /home/rocm-user/eigen/unsupported/Eigen/CXX11/Tensor:117:
/home/rocm-user/eigen/unsupported/Eigen/CXX11/src/Tensor/TensorBlockV2.h:155:5: error: the field type is not amp-compatible
    DestinationBufferKind m_kind;
    ^
/home/rocm-user/eigen/unsupported/Eigen/CXX11/src/Tensor/TensorBlockV2.h:211:3: error: the field type is not amp-compatible
  DestinationBuffer m_destination;
  ^
```


For some reason HIPCC does not like device code to contain enum types which do not have the base-type explicitly declared. The fix is trivial, explicitly state "int" as the basetype
Affected #:  1 file

https://bitbucket.org/eigen/eigen/commits/28668dca1bde/
Changeset:   28668dca1bde
User:        rmlarsen
Date:        2019-10-22 22:18:38+00:00
Summary:     Merged in deven-amd/eigen-hip-fix-191018 (pull request #738)

Fix for the HIP build+test errors.
Affected #:  1 file

Repository URL: https://bitbucket.org/eigen/eigen/

--

This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/