| [eigen-commits] commit/eigen: ezhulenev: PR430: Convert count to the reducer type in MeanReducer |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen-commits Archives
]
- To: eigen-commits@xxxxxxxxxxxxxxxxxxx
- Subject: [eigen-commits] commit/eigen: ezhulenev: PR430: Convert count to the reducer type in MeanReducer
- From: Bitbucket <commits-noreply@xxxxxxxxxxxxx>
- Date: Fri, 20 Jul 2018 07:42:53 +0000 (UTC)
- Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=bitbucket.org; h=mime-version:content-type:content-transfer-encoding:subject:from:to; s=s1; bh=6xbSvrm1qMr+/kr1Lb6kc2RIERI=; b=eG21w0AcnuzA+kSHfR7oYrI EKLPeNYnxkXabPqulaxZSWzkKrSZFhzzv8bxe3uqOhLo1KFUMa9HjpgkXoH8gfyz alSEn1MlLcae31P6kZqjKCF9mKXfLlQJ62sEF+OMc2tuTGGjui2vGN8IAcwJ4rkj H3xMb+fm76q3NWE4kefo=
1 new commit in eigen:
https://bitbucket.org/eigen/eigen/commits/8b22f1ac36ff/
Changeset: 8b22f1ac36ff
User: ezhulenev
Date: 2018-07-20 00:37:03+00:00
Summary: PR430: Convert count to the reducer type in MeanReducer
Without explicit conversion Tensorflow fails to compile, pset1 template deduction fails.
cannot convert '((const Eigen::internal::MeanReducer<Eigen::half>*)this)
->Eigen::internal::MeanReducer<Eigen::half>::packetCount_'
(type 'const DenseIndex {aka const long int}')
to type 'const type& {aka const Eigen::half&}'
return pdiv(vaccum, pset1<Packet>(packetCount_));
Honestly I’m not sure why it works in Eigen tests, because Eigen::half constructor is explicit, and why it stopped working in TF, I didn’t find any relevant changes since previous Eigen upgrade.
static_cast<T>(packetCount_) - breaks cxx11_tensor_reductions test for Eigen::half, also quite surprising.
Affected #: 1 file
Repository URL: https://bitbucket.org/eigen/eigen/
--
This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.