[eigen-commits] commit/eigen: 3 new changesets

[ Thread Index | Date Index | More lists.tuxfamily.org/eigen-commits Archives ]


3 new commits in eigen:

https://bitbucket.org/eigen/eigen/commits/fa63169f4e39/
Changeset:   fa63169f4e39
User:        Moritz Klammler
Date:        2014-07-06 06:58:13
Summary:     Avoid memory leak when constructor of user-defined type throws exception.

The added check `ctorleak.cpp` demonstrates how the leak can be reproduced.
The test appears to pass but it is leaking the storage of the (not created)
matrix.  I don't know how to make this test fail in the existing test suite but
you can run it through Valgrind (or another debugger) to verify the leak.

    $ ./check.sh ctorleak && valgrind --leak-check=full ./test/ctorleak

This patch fixes this leak by adding some try-catch-delete-rethrow blocks to
`Eigen/src/Core/util/Memory.h`.
Affected #:  3 files

https://bitbucket.org/eigen/eigen/commits/28e7d1ac5e63/
Changeset:   28e7d1ac5e63
User:        Moritz Klammler
Date:        2014-07-18 23:19:56
Summary:     Applied changes suggested by Christoph Hertzberg to c'tor leak fix.

- Enclose exception handling in '#ifdef EIGEN_EXCEPTIONS'.
- Use an object counter to demonstrate the bug more readily.
Affected #:  2 files

https://bitbucket.org/eigen/eigen/commits/c071cfb18ffd/
Changeset:   c071cfb18ffd
User:        chtz
Date:        2014-07-22 13:16:44
Summary:     Define EIGEN_TRY, EIGEN_CATCH, EIGEN_THROW as suggested by Moritz Klammer.
Make it possible to run unit-tests with exceptions disabled via EIGEN_TEST_NO_EXCEPTIONS flag.
Enhanced ctorleak unit-test
Affected #:  7 files

Repository URL: https://bitbucket.org/eigen/eigen/

--

This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/