| Re: [eigen-commits] commit/eigen: hauke: Disable variadic macro warning when compiling at full warning level. |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen-commits Archives
]
- To: eigen-commits@xxxxxxxxxxxxxxxxxxx, Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>
- Subject: Re: [eigen-commits] commit/eigen: hauke: Disable variadic macro warning when compiling at full warning level.
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Fri, 29 Jan 2010 06:45:44 -0500
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=f8CZ1gFnZdBOheHGN7kjPjtNXdJEsnU0w1h3NlCqSWE=; b=KUGhZALIOIWodVMQSbjO7FxiVzxSz2S5d6hisDOH8DNg4zSbhvid1fOUlVyEUFXi0k D/rcB+HhN4RJ15tDn9eE3zZph3UhWmsC6hxOuuWQvJ8KHbeKGYESw2Ds2i620vRK+kJf TdEs/EF4Yo+ZDnjU9FtJCPVbsuYc3oQ+t4PXk=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=R3GHtbT2whyMB5CorZyn8XJcO+KrfW4+lHHDvHIOHojzbO+6CK0DYZbC+4aWsGHYHG 6c6QgPW385R0zcUSvxF8bamJeTsm1GBVcgR8q8pgtAQExpNcexmYIr31VurzIHin+ZN5 GEQkcTuWc7vGOrIL7QyZNQTde7HY+5S8Kivrs=
I don't understand this commit. It has the effect of hiding a warning
from us when we build the unit tests, but it won't hide the warning
from our users when they build their own application using Eigen.
Hence we're going to get users confused about this warning, right?
If you need this warning disabled, we need to disable and re-enable it
with pragmas in eigen itself.
2010/1/29 <commits-noreply@xxxxxxxxxxxxx>:
> 1 new changeset in eigen:
>
> http://www.bitbucket.org/eigen/eigen/changeset/e827151721cb/
> changeset: r2403:e827151721cb
> user: hauke
> date: 2010-01-29 09:53:19
> summary: Disable variadic macro warning when compiling at full warning level.
> I was not able to get a macro version running and thus I opted for a cmake patch.
> affected #: 1 file (230 bytes)
>
> Repository URL: http://bitbucket.org/eigen/eigen/
>
> --
> This is a commit notification from bitbucket.org.
> You are receiving this because you have the service
> enabled, addressing the recipient of this email.
>
>
>