| Re: [AD] fixes for some al_resize_display cases in Windows |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
On Sat, 14 Jul 2012 18:47:35 +0200
Dennis-Busch@xxxxxxxxxx wrote:
> On 14 Jul 2012 at 15:59, Elias Pschernig wrote:
> > On Fri, 13 Jul 2012 23:27:23 +0200
> > Dennis-Busch@xxxxxxxxxx wrote:
> >
> > Hm. The code is broken right now. And works with your patch. I'm
> > still not comfortable applying it since I don't understand what it
> > does at all. So it's probably best if Trent looks over it first.
> > Else I'll at least wait until I find time to boot into Windows and
> > re-produce all the issues.
>
> Yes, it's best if he or someone who knows the driver internals better
> double checks the fixes to see if they don't break anything else.
> I have tested it with the examples and the test runners and did not
> find any issues though but that does not mean there are none of
> course.
>
Ok, it doesn't look like anyone else cares enough to double check right
now so I went ahead and applied it. I tried to split it into 4 separate
patches for the 4 things which are fixed. And I discarded the chunk
which just added a comment. Thanks a lot Peter for letting me know about
git add -p :)
So anyway, this way if one of the patches caused a regression it will
hopefully be easier to figure out what to undo in the future.
On my Windows machine ex_fs_resize kinda works now. It still crashes
when trying to set a not available mode (1280x1024), both with and
without the patches. But without the patches nothing at all is
displayed with WGL after the size change so I can confirm an
improvement.
I think some parts of the D3D and WGL display drivers definitely could
need some refactoring though (which would probably as a side effect have
fixed all those issues and likely some remaining ones) :)
Anyway, thanks again for all the work it must have been fixing these
while not being familiar with the code.