| Re: [AD] al_toggle_display_flag ALLEGRO_NOFRAME |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
On Sat Mar 3, 2012, Peter Wang wrote:
> On Sat, 3 Mar 2012 18:08:23 -0700, Thomas Fjellstrom
<tfjellstrom@xxxxxxxxxx> wrote:
> > On Sat Mar 3, 2012, Peter Wang wrote:
> > > Hi,
> > >
> > > Why is the verb "toggle" instead of just "set"?
> > > 5.1 adds al_toggle_menu_item_flags -- that should be reconsidered.
> > >
> > > The NOFRAME flag is just confusing. Both the Windows and X11
> > > implementations got al_toggle_display_flag(ALLEGRO_NOFRAME) wrong.
> > >
> > > Unfortunately we have a few negative flags already, but we should avoid
> > > adding more.
> >
> > I had assumed that toggle did just that. It would add the flag if it
> > wasn't set, and remove it if it was. Anything else is a bug. Given the
> > name it seems the intent is to toggle. So if the code isn't toggling,
> > its broken.
>
> That wouldn't explain the third parameter.
Yeah. I should have looked at the docs. ::)
> Peter
>
> ---------------------------------------------------------------------------
> --- Virtualization & Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
--
Thomas Fjellstrom
tfjellstrom@xxxxxxxxxx