[AD] [ alleg-Bugs-2971924 ] setup/setup is built with insecure RPATH

[SourceForge.net <noreply@xxxxxxxxxx>]

Bugs item #2971924, was opened at 2010-03-17 05:33
Message generated for change (Settings changed) made by elias
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105665&aid=2971924&group_id=5665

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
>Group: 4.4
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Samuli Suominen (ssuominen)
Assigned to: Nobody/Anonymous (nobody)
Summary: setup/setup is built with insecure RPATH

Initial Comment:
By default, setup/setup doesn't install to system even if WANT_X11 is set to ON in cmake. And since it's not installed, it's left by insecure RPATH in the binary.

I suggest adding some install commands to it... In Gentoo Linux, we install it like following:

- Install setup/setup to /usr/bin/allegro-setup (because setup is too common name)
- Install keyboard.dat, language.dat and setup/setup.dat to /usr/share/allegro
- Install misc/icon.png to /usr/share/pixmaps/allegro.png

And then create a freedesktop.org compatible .desktop entry for it, into /usr/share/applications/allegro-setup.desktop, like this:

[Desktop Entry]
Name=Allegro Setup
Type=Application
Exec=allegro-setup
TryExec=allegro-setup
Icon=allegro
Categories=Settings;

As a workaround, because of the missing installation handling, I'm also adding:

--- setup/CMakeLists.txt
+++ setup/CMakeLists.txt
@@ -1,3 +1,5 @@
+set(CMAKE_SKIP_BUILD_RPATH TRUE)
+
 add_our_executable(setup setup.c)
 copy_files(copy_setup_data setup.dat)

above line to setup/CMakeLists.txt, but this should not be required if the CMakeLists.txt is equipped with proper install commands

----------------------------------------------------------------------

Comment By: Thomas Fjellstrom (strangemoose)
Date: 2010-03-17 14:52

Message:
As far as I know, setup should not be installed. The intent was for games
to distribute it along with their own exe, back when games would all stuff
their binaries and data all in the same folder on dos and windows. In unix,
it doesn't really have a place.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105665&aid=2971924&group_id=5665