[AD] [ alleg-Bugs-3298206 ] al_remove_filename() returns wrong code.

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


Bugs item #3298206, was opened at 2011-05-06 11:15
Message generated for change (Comment added) made by xpolife
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105665&aid=3298206&group_id=5665

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core Library
Group: None
Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By:  xpol (xpolife)
Assigned to: Nobody/Anonymous (nobody)
Summary: al_remove_filename() returns wrong code.

Initial Comment:
al_remove_filename() returns false even it runs successfully.

It is caused by fs_stdio_remove_filename() in /src/fshook_stdio.c

the line checking the return code of fs_stdio_remove_entry()

   if (err != 0) {

should change to 

   if (err) {

as fs_stdio_remove_entry() return "true" on success.





----------------------------------------------------------------------

Comment By:  xpol (xpolife)
Date: 2011-05-09 15:02

Message:
Thanks for fixing it!

I will double check next time!

----------------------------------------------------------------------

Comment By: Peter Wang (tjaden)
Date: 2011-05-06 13:40

Message:
Thanks.

Though your suggested fix was wrong, as if (err) and if (err != 0) are
entirely equivalent.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105665&aid=3298206&group_id=5665




Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/