| Re: [AD] file interface fopen |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
On 2010-12-20, Matthew Leverton <meffer@xxxxxxxxxx> wrote:
> On Mon, Dec 20, 2010 at 4:25 PM, Peter Wang <novalazy@xxxxxxxxxx> wrote:
> >
> > You forgot to free the ALLEGRO_FILE handle in al_fclose.
> >
> The fi_close methods were freeing it, but I've now moved it into
> al_fclose, since al_fopen is allocating it. The attached patch
> addresses that along with the other things mentioned.
>
> What about al_create_file_handle vs al_create_file_handle_vt ?
Delete al_create_file_handle and
rename al_create_file_handle_vt to al_create_file_handle.
al_fopen_vt isn't the best name but we can rename it after
you commit, if a better suggestion comes up.
Peter