[AD] [ alleg-Bugs-3056932 ] al_current_time does not fit Allegro naming convention

["SourceForge.net" <noreply@xxxxxxxxxx>]

Bugs item #3056932, was opened at 2010-08-31 18:48
Message generated for change (Comment added) made by elias
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105665&aid=3056932&group_id=5665

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Core Library
Group: 4.9
Status: Open
Resolution: None
Priority: 3
Private: No
Submitted By: Mateusz Jończyk (mat2)
Assigned to: Nobody/Anonymous (nobody)
Summary: al_current_time does not fit Allegro naming convention

Initial Comment:
Should there be al_get_current_time() instead of al_current_time() ?

----------------------------------------------------------------------

>Comment By: Elias Pschernig (elias)
Date: 2010-08-31 19:29

Message:
Yes, it should be al_get_current_time(). I'll change it unless someone sees
a problem.

With the _is_ there are more cases, for example:
al_event_queue_is_empty -> al_is_event_queue_empty

I would agree and say always using al_is_* makes most sense for them but I
do remember a discussion about this once so will wait for more input.

----------------------------------------------------------------------

Comment By: Evert Glebbeek (eglebbk)
Date: 2010-08-31 19:27

Message:
Agreed taht it should be al_get_current_time().
Disagree about the others, to various degrees. Something like "if
(al_is_timer_started())" just reads wrong to me. Similar with
"al_was_mouse_button_held()", it sounds contrived.
Those changes, I think, actually make things harder because they don't
read natural.

----------------------------------------------------------------------

Comment By: Mateusz Jończyk (mat2)
Date: 2010-08-31 19:01

Message:
Maybe al_was_mouse_button_held(), al_was_key_down(),
al_turn_keycode_to_name() ?

----------------------------------------------------------------------

Comment By: Mateusz Jończyk (mat2)
Date: 2010-08-31 18:58

Message:
Other entries:

al_timer_is_started()                          ->    
al_is_timer_started()


al_fs_entry_is_file ()                                        -> 
al_is_fs_entry_file()             (???)
al_fs_entry_is_directory ()                               ->
al_is_fs_entry_directory()      (???)

Everything else does fit to the convention( except al_mouse_button_down(),
al_key_down(), al_keycode_to_name(), but I don't see a sensible way of
"correcting" them)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105665&aid=3056932&group_id=5665