Re: [AD] al_assert

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


On Tue, 2010-02-23 at 17:40 -0500, Evert Glebbeek wrote:
> On 23 Feb 2010, at 15:36 , Peter Hull wrote:
> > OK, raising this thread from the dead, but, can I add the noreturn
> > attribute to al_assert and make sure it doesn't actually return? It
> > cuts out all the null pointer dereference errors from the clang static
> > analysis that Evert and I have been running.
> 
> No idea what it does or why we shouldn't do it (I don't remember the
> thread), but you can always add it on only on OS X if it interferes
> with other platforms.
> 

Can we do this?

#define AL_ASSERT assert

Basically every line in al_assert() seems completely useless to me. I'm
sure it made sense in the days of A4 somehow but looking at that code
now I honestly don't see what it does. There's an assert_handler which
is not used anywhere else according to git grep. And an undocumented
ALLEGRO_ASSERT environment variable, which optionally writes to a file?
As much as I try to find one I can't see a possibly use case for that.

-- 
Elias Pschernig <elias.pschernig@xxxxxxxxxx>





Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/