Re: [AD] locking problem on OpenGL

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


On Sun, 2009-08-16 at 17:23 +1000, Peter Wang wrote:
> On 2009-08-16, Peter Wang <novalazy@xxxxxxxxxx> wrote:
> > Or should we change ogl_lock_region to account for the alignment in the
> > first place?
> 
> Actually, I think this is the right option so I went ahead and committed
> something.

Yeah. I couldn't find anything - but I guess it may be faster to keep
the alignment like this.

> 
> With regards to pixel format conversions, I found more errors:
> 
>     ARGB4444 -> RGBX8888
>     RGB565 -> RGB555
>     RGB565 -> RGBA5551
>     RGB565 -> ARGB1555
>     RGB565 -> BGR555
>
> Also, compare ARGB4444->ARGB888 and RGBA4444->ARGB8888.  They should be
> identical but the second one has a greenish tint compared to the first.
> This occurs with a few combinations.

Some conversions use _rgb_scale_4[x] to convert 0..15 -> 0..255, some
use x << 4 (which means 0..15 -> 0..240). Guess we should use _rgb_scale
everywhere.

> 
> Since the conversions should be automatically generated soon(?) I didn't
> bother to fix them.
> 

Yes, all of the 5 above were automatically fixed. Guess I'll commit the
generated files.

-- 
Elias Pschernig <elias@xxxxxxxxxx>





Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/