| Re: [AD] SF.net SVN: alleg:[12193] allegro/branches/4.9/addons/memfile/memfile.c |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
- To: Coordination of admins/developers of the game programming library Allegro <alleg-developers@xxxxxxxxxx>
- Subject: Re: [AD] SF.net SVN: alleg:[12193] allegro/branches/4.9/addons/memfile/memfile.c
- From: Evert Glebbeek <eglebbk@xxxxxxxxxx>
- Date: Mon, 11 May 2009 04:27:39 +0200
On 10 May 2009, at 16:30 , elias@xxxxxxxxxx wrote:
Log Message:
-----------
Fixed two warnings. Can't we replace all uses of size_t and offset_t
with int64_t?
No.
- if (mf->size - mf->pos < size) {
+ if (mf->size - mf->pos < (int64_t)size) {
Isn't the logic backwards here?
Shouldn't the LHS of the comparison here rather be size_t?
Evert