Re: [AD] SF.net SVN: alleg:[11136] allegro/branches/4.9

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


On 22 Oct 2008, at 14:32, mmimica@xxxxxxxxxx wrote:
Log Message:
-----------
Made _al_blend, just like _al_put_pixel take the dest bitmap parametar instead of looking up TLS. This fixes a problem with blending with the wrong color in case of
sub bitmaps.
[...]
-         _al_blend(&src_color, x+dx, y+dy, &result);
+         _al_blend(&src_color, dest, x+dx, y+dy, &result);
          _al_put_pixel(dest, xd+dx, yd+dy, result);

I was going to suggest changing that to put the dest bitmap in _al_blend first, to mirror _al_put_pixel, but looking at it from a different perspective, you're blending src_color to a target and the target arguments should logically be kept together.

Does anyone else have thoughts on this? I know it's a minor point we don't really need to worry about. ;)

Evert




Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/