Re: [AD] Patch to allow Allegro 4.3.10plus to build on Haiku

["scott mc" <scottmc2@xxxxxxxxxx>]

On Tue, Oct 21, 2008 at 12:44 AM, Peter Wang <novalazy@xxxxxxxxxx> wrote:
> On 2008-10-21, scott mc <scottmc2@xxxxxxxxxx> wrote:
>> On Mon, Oct 20, 2008 at 10:11 PM, Peter Wang <novalazy@xxxxxxxxxx> wrote:
>> > On 2008-10-20, scott mc <scottmc2@xxxxxxxxxx> wrote:
>> >>
>> >> For TRACE I'm getting an error:
>> >> arguments given to macro `TRACE'
>> >>
>> >> Here's my terminal session trying to build 4.3.10plus r11120 on haiku.
>> >>  When hitting one of the TRACE cases, I commented that line out and
>> >> reran make. I clipped out the redundant parts of the terminal session.
>> >
>> > I think I've found the bug. In bealleg.h there is a line:
>> >
>> >    # undef TRACE
>> >
>> > Hence, it's not calling Allegro's TRACE at all.  Do the BeOS headers
>> > define TRACE?  We should probably rename ours to _AL_TRACE or something.
> ...
>>
>> Ok, trying with r11124, I got the TRACE error, so I commented out the
>> undef in bealleg.h, and not got this:
>> In file included from /boot/develop/headers/be/SupportKit.h:13,
>>                  from /boot/develop/headers/be/Be.h:14,
>>                  from /boot/home/allegro/include/bealleg.h:51,
>>                  from /boot/home/allegro/src/beos/baccel.cpp:19:
>> /boot/develop/headers/be/support/Debug.h:77: warning: `TRACE' redefined
>
> Ok.
>
>> So yes, perhaps _AL_TRACE_ might be a good idea.
>
> Unfortunately TRACE is part of the Allegro public API, so we can't just
> rename it.  However, we could add AL_TRACE (for example) and keep TRACE

I figured that might be the case.

> for compatibility.  We need to do something similar in 4.9 anyway as we
> have a policy of reducing our namespace pollution there.
>
> Peter

I changed the TRACE to AL_TRACE to get passed the few cases that were
failing and now get this error.  This is where the empty directory
fixed things:

gcc -DALLEGRO_LIB_BUILD -Wall -Wno-unused -Wno-multichar
-Wno-ctor-dtor-privacy -mcpu=i586 -O6 -funroll-loops -ffast-math
-fomit-frame-pointer -DALLEGRO_NO_ASM -I. -I./include -o
obj/beos/alleg/beos/bfixicon.o -c tools/beos/bfixicon.cpp
Assembler messages:
FATAL: can't create obj/beos/alleg/beos/bfixicon.o: No such file or directory
make[1]: *** [obj/beos/alleg/beos/bfixicon.o] Error 1
make[1]: Leaving directory `/boot/home/allegro'
make: *** [programs] Error 2
~/allegro>

-scott