| Re: [AD] SF.net SVN: alleg:[10863] allegro/branches/4.9/addons/iio/CMakeLists.txt |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
On Thursday 18 September 2008, Peter Wang wrote:
> On 2008-09-18, trentg@xxxxxxxxxx <trentg@xxxxxxxxxx>
wrote:
> > Revision: 10863
> > http://alleg.svn.sourceforge.net/alleg/?rev=10863&view=rev
> > Author: trentg
> > Date: 2008-09-18 20:08:54 +0000 (Thu, 18 Sep 2008)
> >
> > Log Message:
> > -----------
> > Small fix for IIO cmake
> >
> > Modified Paths:
> > --------------
> > allegro/branches/4.9/addons/iio/CMakeLists.txt
> >
> > Modified: allegro/branches/4.9/addons/iio/CMakeLists.txt
> > ===================================================================
> > --- allegro/branches/4.9/addons/iio/CMakeLists.txt 2008-09-18 14:06:12
> > UTC (rev 10862) +++
> > allegro/branches/4.9/addons/iio/CMakeLists.txt 2008-09-18 20:08:54 UTC
> > (rev 10863) @@ -4,7 +4,7 @@
> > if(WANT_PNG)
> > include(FindPNG)
> > if(PNG_FOUND)
> > - set(ALLEGRO_CFG_IIO_HAVE_PNG 1)
> > + set(ALLEGRO_CFG_IIO_HAVE_PNG "-DALLEGRO_CFG_IIO_HAVE_PNG")
> > list(APPEND IIO_SOURCES png.c)
> > set(IIO_LIBRARIES ${PNG_LIBRARIES})
> > set(IIO_DEFINES ${PNG_DEFINITIONS})
> > @@ -22,7 +22,7 @@
> > add_library(${target} ${libtype} ${IIO_SOURCES})
> > set_target_properties(${target}
> > PROPERTIES
> > - COMPILE_FLAGS "${more_extra_flags} ${IIO_DEFINES}
> > ${LIBRARY_CFLAGS} -DA5_IIO_SRC" + COMPILE_FLAGS
> > "${more_extra_flags} ${IIO_DEFINES} ${LIBRARY_CFLAGS} -DA5_IIO_SRC
> > ${ALLEGRO_CFG_IIO_HAVE_PNG}" OUTPUT_NAME ${nm2}
> > )
>
> I understand that Todd Cope couldn't get PNG support working, but this
> hack doesn't make any sense. If he has problems with PNG then he should
> have the same problems with all the other external dependencies as well.
>
> Peter
>
I'm having issues with png and zlib under mingw as well. It detects mostly
everything, but not libpng or zlib without me forcing it to look in the dir I
installed it in (mingw's dir actually, so it should have been found).
I think it may be an issue with CMake's FindPNG and FindZLIB macros.
--
Thomas Fjellstrom
tfjellstrom@xxxxxxxxxx