Re: [AD] include path fixup patch.

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


Review follows.

> Index: makefile.lst
> ===================================================================
> --- makefile.lst	(revision 9797)
> +++ makefile.lst	(working copy)
> @@ -3,6 +3,8 @@
>  ALLEGRO_SRC_FILES = \
>  	src/allegro.c \
>  	src/blit.c \
> +	src/blenders.c \
> +	src/bitmap_new.c \
>  	src/bmp.c \
>  	src/clip3d.c \
>  	src/clip3df.c \
> @@ -14,7 +16,8 @@
>  	src/digmid.c \
>  	src/dither.c \
>  	src/dispsw.c \
> -        src/display.c \
> +	src/display.c \
> +	src/display_new.c \
>  	src/dtor.c \
>  	src/drvlist.c \
>  	src/events.c \
> @@ -49,6 +52,7 @@
>  	src/modesel.c \
>  	src/mousenu.c \
>  	src/pcx.c \
> +	src/pixels.c \
>  	src/poly3d.c \
>  	src/polygon.c \
>  	src/quantize.c \
> @@ -76,7 +80,14 @@
>  	src/compat/cokeybd.c \
>  	src/compat/comouse.c \
>  	src/compat/cotimer.c \
> -	src/misc/vector.c
> +	src/misc/vector.c \
> +	src/memblit1.c \
> +	src/memblit.c \
> +	src/memblit2.c \
> +	src/memdraw.c \
> +	src/system_new.c \
> +	src/memblit3.c \
> +	src/convert.c

Sort that.

>  
>  ALLEGRO_SRC_C_FILES = \
>  	src/c/cblit16.c \
> @@ -350,6 +361,15 @@
>  	src/x/xdga2s.s \
>  	src/x/xwins.s \
>  	src/misc/colconv.c
> +
> +ALLEGRO_SRC_XGLX_FILES = \
> +	src/xglx/xbitmap.c \
> +	src/xglx/xcompat.c \
> +	src/xglx/xdisplay.c \
> +	src/xglx/xdraw.c \
> +	src/xglx/xfullscreen.c \
> +	src/xglx/xglx_config.c \
> +	src/xglx/xsystem.c
>  	
>  ALLEGRO_SRC_QNX_FILES = \
>  	src/qnx/qdrivers.c \
> @@ -545,7 +565,6 @@
>  	examples/exmem.c \
>  	examples/exmidi.c \
>  	examples/exmouse.c \
> -	examples/exnew_events.c \
>  	examples/expackf.c \
>  	examples/expal.c \
>  	examples/expat.c \
> @@ -568,7 +587,16 @@
>  	examples/exunicod.c \
>  	examples/exupdate.c \
>  	examples/exxfade.c \
> -	examples/exzbuf.c
> +	examples/exzbuf.c \
> +	examples/exnewapi.c \
> +	examples/exnew_bitmap.c \
> +	examples/exnew_fs_resize.c \
> +	examples/exnew_icon.c \
> +	examples/exnew_lockbitmap.c \
> +	examples/exnew_lockscreen.c \
> +	examples/exnew_mouse.c \
> +	examples/exnew_mouse_events.c \
> +	examples/exnew_resize.c

Yeah, might as well be consistent and sort the whole list.

> @@ -620,7 +647,16 @@
>  	examples/exunicod \
>  	examples/exupdate \
>  	examples/exxfade \
> -	examples/exzbuf
> +	examples/exzbuf \
> +	examples/exnewapi \
> +	examples/exnew_bitmap \
> +	examples/exnew_fs_resize \
> +	examples/exnew_icon \
> +	examples/exnew_lockbitmap \
> +	examples/exnew_lockscreen \
> +	examples/exnew_mouse \
> +	examples/exnew_mouse_events \
> +	examples/exnew_resize

Ditto.

> Index: misc/grabdeps.pl
> ===================================================================
> --- misc/grabdeps.pl	(revision 0)
> +++ misc/grabdeps.pl	(revision 0)
> @@ -0,0 +1,52 @@
> +#!/usr/bin/perl
> +
> +=pod
> +
> +=head1 DESCRIPTION
> +
> +This script is called from misc/deplib.sh to I<properly> grab dependencies for a list of source files.
> +It assumes its being run from the base allegro directory.

Personally, I prefer lines to be wrapped at 80 chars or less, even if it's not
required in Allegro.

> Index: misc/checklst.pl
> ===================================================================
> --- misc/checklst.pl	(revision 0)
> +++ misc/checklst.pl	(revision 0)
> @@ -0,0 +1,71 @@
> +#!/usr/bin/perl
> +
> +=pod
> +
> +=head1 DESCRIPTION
> +
> +This script checks to see if there are any files that exist in the main source dir, and aren't in makefile.lst.
> +It currently only checks src/ against ALLEGRO_SRC_FILES. Though it can easily be expanded to the platform dirs as well.

That should be one sentence.

> +It's more of a handy utility for someone that might want to keep the makefiles up to do date, incase others have been lax.

s/incase/in case/

Ok, commit that.

Peter





Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/