Re: [AD] proposal: draw_sprite_*_ex

[Victor <vwss1984@xxxxxxxxxx>]

Why to have this:

#define DRAW_SPRITE_NO_FLIP 1
#define DRAW_SPRITE_H_FLIP 2
#define DRAW_SPRITE_V_FLIP 4

Instead of this:

#define DRAW_SPRITE_NO_FLIP 0
#define DRAW_SPRITE_H_FLIP 1
#define DRAW_SPRITE_V_FLIP 2
#define DRAW_SPRITE_VH_FLIP 3 // (DRAW_SPRITE_VH_FLIP == DRAW_SPRITE_H_FLIP |
 DRAW_SPRITE_V_FLIP)
Victor Williams Stafusa da Silva

Peter Wang <novalazy@xxxxxxxxxx> escreveu:

On 2007-10-07, Milan Mimica wrote:
> Jon Rafkind wrote:
> > Ok I changed draw_sprite_ex to accept another parameter, flip which can
>
> Can this patch be applied now to 4.3.10plus? I tested it and the only
> problem I noticed is that extrans was not compiled because it was
> missing in ALLEGRO_EXAMPLE_EXES list in makefile.lst. Was that intentional?
>
> > be one of the above mentioned constants. I changed SPRITE_LIT to
> > DRAW_SPRITE_LIT but its still just a define and not an enum. Should it
> > be an enum?
> >
> > I define the constants above as
> > #define DRAW_SPRITE_NO_FLIP 1
> > #define DRAW_SPRITE_H_FLIP 2
> > #define DRAW_SPRITE_V_FLIP 4
>
> DRAW_SPRITE_NO_FLIP | DRAW_SPRITE_H_FLIP Is the only open issue.
> Can't we just have DRAW_SPRITE_HV_FLIP and not allow or-ing?

I don't remember why I suggesting OR-ing, so I have no problem
with that.

The patch needs some reformatting.

Peter


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
--
https://lists.sourceforge.net/lists/listinfo/alleg-developers

Abra sua conta no Yahoo! Mail, o único sem limite de espaço para armazenamento!