Re: [AD] [ alleg-Bugs-1650580 ] Problem in fixed point library.

[Thomas Fjellstrom <tfjellstrom@xxxxxxxxxx>]

On Sunday 04 February 2007 7:18 am, Peter Wang wrote:
> On 2007-02-04, Elias Pschernig <elias@xxxxxxxxxx> wrote:
> > I'll apply the below patch if nobody objects - the bug reporter claims
> > to have tested it, and LONG_LONG also is used for fixmul so should cause
> > no problem here.
> >
> > Index: include/allegro/inline/fmaths.inl
> > ===================================================================
> > --- include/allegro/inline/fmaths.inl   (revision 7706)
> > +++ include/allegro/inline/fmaths.inl   (working copy)
> > @@ -151,7 +151,7 @@
> >        return (x < 0) ? -0x7FFFFFFF : 0x7FFFFFFF;
> >     }
> >     else
> > -      return ftofix(fixtof(x) / fixtof(y));
> > +      return ((LONG_LONG)x << 16) / (LONG_LONG)y;
> >  })
>
> Didn't we discuss the fixed point functions on allegro.cc last year or
> so?  Don't apply this just yet.

It can always be reversed, and if it means waiting another year...

> Peter
>
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job
> easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache
> Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

-- 
Thomas Fjellstrom
tfjellstrom@xxxxxxxxxx